Merge ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-30.1-noble into ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel

Proposed by Grant Orndorff
Status: Needs review
Proposed branch: ~orndorffgrant/ubuntu/+source/ubuntu-advantage-tools:upload-30.1-noble
Merge into: ubuntu/+source/ubuntu-advantage-tools:ubuntu/devel
Diff against target: 35 lines (+8/-1)
2 files modified
debian/changelog (+6/-0)
uaclient/version.py (+2/-1)
Reviewer Review Type Date Requested Status
Simon Quigley (community) Approve
Bryce Harrington (community) Approve
Review via email: mp+455807@code.launchpad.net

Description of the change

Fixes #2043836

Do we need to address any of the other errors that halted phasing of v30? https://ubuntu-archive-team.ubuntu.com/phased-updates.html

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM, +1

$ dput ubuntu ../ubuntu-advantage-tools_30.1_source.changes
D: Setting host argument.
Checking signature on .changes
gpg: ../ubuntu-advantage-tools_30.1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: ../ubuntu-advantage-tools_30.1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_30.1.dsc: done.
  Uploading ubuntu-advantage-tools_30.1.tar.xz: done.
  Uploading ubuntu-advantage-tools_30.1_source.buildinfo: done.
  Uploading ubuntu-advantage-tools_30.1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
Simon Quigley (tsimonq2) :
review: Approve

Unmerged commits

5faf627... by Grant Orndorff

version 30.1

1aed988... by Grant Orndorff

version: fix UnboundLocalError in error-handling

LP: #2043836

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 78901ae..5facae5 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+ubuntu-advantage-tools (30.1) noble; urgency=medium
7+
8+ * fix UnboundLocalError in update-check error handling (LP: #2043836)
9+
10+ -- Grant Orndorff <grant.orndorff@canonical.com> Fri, 17 Nov 2023 14:25:22 -0500
11+
12 ubuntu-advantage-tools (30) noble; urgency=medium
13
14 * d/control:
15diff --git a/uaclient/version.py b/uaclient/version.py
16index 1a26f8f..aceff72 100644
17--- a/uaclient/version.py
18+++ b/uaclient/version.py
19@@ -14,7 +14,7 @@ from uaclient.defaults import CANDIDATE_CACHE_PATH, UAC_RUN_PATH
20 from uaclient.exceptions import ProcessExecutionError
21 from uaclient.system import subp
22
23-__VERSION__ = "30"
24+__VERSION__ = "30.1"
25 PACKAGED_VERSION = "@@PACKAGED_VERSION@@"
26
27
28@@ -51,6 +51,7 @@ def get_last_known_candidate() -> Optional[str]:
29 not os.path.exists(CANDIDATE_CACHE_PATH)
30 or os.stat(CANDIDATE_CACHE_PATH).st_mtime < last_apt_cache_update
31 ):
32+ candidate_version = None
33 try:
34 candidate_version = get_pkg_candidate_version(
35 "ubuntu-advantage-tools"

Subscribers

People subscribed via source and target branches

to status/vote changes: