Merge lp:~ories/ubuntu-weather-app/unity8_preview_fix into lp:ubuntu-weather-app/obsolete.trunk

Proposed by Olli Ries
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 236
Merged at revision: 236
Proposed branch: lp:~ories/ubuntu-weather-app/unity8_preview_fix
Merge into: lp:ubuntu-weather-app/obsolete.trunk
Diff against target: 8 lines (+1/-1)
1 file modified
ubuntu-weather-app.in (+1/-1)
To merge this branch: bzr merge lp:~ories/ubuntu-weather-app/unity8_preview_fix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Nekhelesh Ramananthan (community) Approve
Review via email: mp+216167@code.launchpad.net

Commit message

Added "exec" to the script launcher to fix launching clock app in the Unity 8 Desktop Preview

Description of the change

as per https://bugs.launchpad.net/ubuntu/+source/unity8-desktop-session/+bug/1300911, comment #2

added "exec" to maintain same PID in order to establish connection to Mir

To post a comment you must log in.
Revision history for this message
Olli Ries (ories) wrote :

it will need testing on the phone, I tested U7/Desktop and U8/Desktop preview

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Same approach has been used in the clock app and approved by Michael Saviq. Hence approving this one.

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Looks good!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-weather-app.in'
2--- ubuntu-weather-app.in 2014-02-04 15:22:19 +0000
3+++ ubuntu-weather-app.in 2014-04-16 17:48:20 +0000
4@@ -1,3 +1,3 @@
5 #!/bin/bash
6 export QT_SELECT=qt5
7-qmlscene @CMAKE_INSTALL_PREFIX@/@DATA_DIR@/@MAIN_QML@
8+exec qmlscene @CMAKE_INSTALL_PREFIX@/@DATA_DIR@/@MAIN_QML@

Subscribers

People subscribed via source and target branches