Merge lp:~ories/ubuntu-clock-app/unity8_preview_fix into lp:ubuntu-clock-app/saucy

Proposed by Olli Ries
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 397
Merged at revision: 397
Proposed branch: lp:~ories/ubuntu-clock-app/unity8_preview_fix
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 8 lines (+1/-1)
1 file modified
ubuntu-clock-app.in (+1/-1)
To merge this branch: bzr merge lp:~ories/ubuntu-clock-app/unity8_preview_fix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michał Sawicz (community) Approve
Review via email: mp+216152@code.launchpad.net

Commit message

Added "exec" to the script launcher to fix launching clock app in the Unity 8 Desktop Preview

Description of the change

as per https://bugs.launchpad.net/ubuntu/+source/unity8-desktop-session/+bug/1300911, comment #2

added "exec" to maintain same PID in order to establish connection to Mir

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

I installed it on the phone using click-buddy --dir . --provision and it seems to work fine. So I can say nothing regressed. However this has to be tested on Unity 8 Desktop preview.

Revision history for this message
Olli Ries (ories) wrote :

I have tested U7/Desktop and U8/Desktop preview

Revision history for this message
Michał Sawicz (saviq) wrote :

Yes, this is fine. Means only that the qmlscene process will replace the bash PID, which is required for Unity8 to accept the connection.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~ories/ubuntu-clock-app/unity8_preview_fix/+merge/216152/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-clock-app.in'
2--- ubuntu-clock-app.in 2014-02-04 15:02:26 +0000
3+++ ubuntu-clock-app.in 2014-04-16 16:24:46 +0000
4@@ -1,3 +1,3 @@
5 #!/bin/bash
6 export QT_SELECT=qt5
7-qmlscene @CMAKE_INSTALL_PREFIX@/@DATA_DIR@/@MAIN_QML@
8+exec qmlscene @CMAKE_INSTALL_PREFIX@/@DATA_DIR@/@MAIN_QML@

Subscribers

People subscribed via source and target branches