Sudoku App

Merge lp:~ories/sudoku-app/unity8_preview_fix into lp:sudoku-app

  1. unity8_preview_fix
  2. Merge into trunk
Proposed by Olli Ries
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 187
Merged at revision: 187
Proposed branch: lp:~ories/sudoku-app/unity8_preview_fix
Merge into: lp:sudoku-app
Diff against target: 7 lines (+1/-1)
1 file modified
sudoku-app (+1/-1)
To merge this branch: bzr merge lp:~ories/sudoku-app/unity8_preview_fix
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Nekhelesh Ramananthan (community) Approve
Review via email: mp+216173@code.launchpad.net

Commit message

Added "exec" to the script launcher to fix launching clock app in the Unity 8 Desktop Preview

Description of the change

as per https://bugs.launchpad.net/ubuntu/+source/unity8-desktop-session/+bug/1300911, comment #2

added "exec" to maintain same PID in order to establish connection to Mir

I have tested it on U7/Desktop and U8/Desktop preview, it will need testing on the phone

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Same approach has been used in the clock app and approved by Michael Saviq. Hence approving this one.

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Looks good to me.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~ories/sudoku-app/unity8_preview_fix/+merge/216173/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sudoku-app'
2--- sudoku-app 2013-06-14 07:50:03 +0000
3+++ sudoku-app 2014-04-16 18:01:09 +0000
4@@ -1,2 +1,2 @@
5 #!/bin/bash
6-qmlscene /usr/share/sudoku-app/sudoku-app.qml
7+exec qmlscene /usr/share/sudoku-app/sudoku-app.qml

Subscribers

People subscribed via source and target branches