Merge lp:~openupgrade-committers/openupgrade-addons/7.0-account_analytic_plans-pedro.baeza into lp:openupgrade-addons

[Stefan Rijnhart (Opener)]

Reup of https://code.launchpad.net/~pedro.baeza/openupgrade-addons/7.0-account_analytic_plans/+merge/209051

[Pedro Manuel Baeza (pedro.baeza)]

Thanks for the backup! As you can see, it's a simple workaround (creating a support analytic plan) for avoiding empty values on the line table. BTW, very strange case.

Regards.

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks Pedro!

I'm looking at the code and I see that the plan_id was required in the form already in 6.1. Lines could however end up without a plan_id if the plan was deleted. This solution is as good as any. Maybe jot down a note in user_notes.txt that any dangling lines will be linked to a specially created plan by the name of 'OpenUpgrade migration plan'?

review: Needs Information

[Pedro Manuel Baeza (pedro.baeza)]

I have added the user notes for the module. Thanks for the suggestion.

Regards.

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

=== added file 'account_analytic_plans/migrations/7.0.1.0/openupgrade_analysis_work.txt'
--- account_analytic_plans/migrations/7.0.1.0/openupgrade_analysis_work.txt	1970-01-01 00:00:00 +0000
+++ account_analytic_plans/migrations/7.0.1.0/openupgrade_analysis_work.txt	2014-03-10 15:37:31 +0000
@@ -0,0 +1,10 @@
+---Fields in module 'account_analytic_plans'---
+account_analytic_plans / account.analytic.plan.line / plan_id (many2one)            : now required
+### -> Created script for filling it for empty values
+
+---XML records in module 'account_analytic_plans'---
+DEL account.journal.column: account.journal_col11
+DEL ir.actions.act_window: account_analytic_plans.account_analytic_plan_form_action_installer
+DEL ir.actions.todo: account_analytic_plans.account_analytic_plan_installer_todo
+### -> Nothing to do
+

=== added file 'account_analytic_plans/migrations/7.0.1.0/pre-migration.py'
--- account_analytic_plans/migrations/7.0.1.0/pre-migration.py	1970-01-01 00:00:00 +0000
+++ account_analytic_plans/migrations/7.0.1.0/pre-migration.py	2014-03-10 15:37:31 +0000
@@ -0,0 +1,44 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This migration script copyright (C) 2014
+#            Pedro M. Baeza ([e-mail])
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openupgrade import openupgrade
+
[e-mail]()
+def migrate(cr, version):
+    # look for account.analytic.plan.line without plan_id
+    cr.execute("""
+        SELECT id
+        FROM account_analytic_plan_line
+        WHERE plan_id is NULL""")
+    record = cr.fetchone()
+    if record:
+        # Create support plan 
+        logged_query(cr, ("""
+            INSERT INTO account_analytic_plan ('name')
+            FROM account_analytic_plan_line
+            VALUES ('OpenUpgrade migration plan')""")
+        # Fill empty values with this new record value
+        logged_query(cr, ("""
+            UPDATE account_analytic_plan_line
+            SET plan_id = 
+                (SELECT id FROM account_analytic_plan 
+                 WHERE NAME='OpenUpgrade migration plan')
+            WHERE plan_id is NULL""")

=== added file 'account_analytic_plans/migrations/7.0.1.0/user_notes.txt'
--- account_analytic_plans/migrations/7.0.1.0/user_notes.txt	1970-01-01 00:00:00 +0000
+++ account_analytic_plans/migrations/7.0.1.0/user_notes.txt	2014-03-10 15:37:31 +0000
@@ -0,0 +1,2 @@
+1) Any dangling analytic plan line (line without any plan) will be linked to a
+specially created plan by the name of 'OpenUpgrade migration plan'.