Merge lp:~openstack-charmers/charm-helpers/0mq into lp:charm-helpers

Proposed by Liam Young
Status: Merged
Merged at revision: 320
Proposed branch: lp:~openstack-charmers/charm-helpers/0mq
Merge into: lp:charm-helpers
Diff against target: 49 lines (+19/-2)
3 files modified
charmhelpers/contrib/openstack/context.py (+2/-0)
charmhelpers/contrib/openstack/templates/zeromq (+14/-0)
tests/contrib/openstack/test_os_contexts.py (+3/-2)
To merge this branch: bzr merge lp:~openstack-charmers/charm-helpers/0mq
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
James Page Approve
Review via email: mp+238855@code.launchpad.net

Description of the change

Add 0mq support

To post a comment you must log in.
Revision history for this message
James Page (james-page) :
review: Approve
Revision history for this message
Liam Young (gnuoy) wrote :

approve

review: Approve
320. By James Page

[james-page,r=gnuoy] Add redis support for zeromq helpers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/contrib/openstack/context.py'
2--- charmhelpers/contrib/openstack/context.py 2015-01-22 06:11:15 +0000
3+++ charmhelpers/contrib/openstack/context.py 2015-02-24 11:28:04 +0000
4@@ -1021,6 +1021,8 @@
5 for unit in related_units(rid):
6 ctxt['zmq_nonce'] = relation_get('nonce', unit, rid)
7 ctxt['zmq_host'] = relation_get('host', unit, rid)
8+ ctxt['zmq_redis_address'] = relation_get(
9+ 'zmq_redis_address', unit, rid)
10
11 return ctxt
12
13
14=== added file 'charmhelpers/contrib/openstack/templates/zeromq'
15--- charmhelpers/contrib/openstack/templates/zeromq 1970-01-01 00:00:00 +0000
16+++ charmhelpers/contrib/openstack/templates/zeromq 2015-02-24 11:28:04 +0000
17@@ -0,0 +1,14 @@
18+{% if zmq_host -%}
19+# ZeroMQ configuration (restart-nonce: {{ zmq_nonce }})
20+rpc_backend = zmq
21+rpc_zmq_host = {{ zmq_host }}
22+{% if zmq_redis_address -%}
23+rpc_zmq_matchmaker = oslo.messaging._drivers.matchmaker_redis.MatchMakerRedis
24+matchmaker_heartbeat_freq = 15
25+matchmaker_heartbeat_ttl = 30
26+[matchmaker_redis]
27+host = {{ zmq_redis_address }}
28+{% else -%}
29+rpc_zmq_matchmaker = oslo.messaging._drivers.matchmaker_ring.MatchMakerRing
30+{% endif -%}
31+{% endif -%}
32
33=== modified file 'tests/contrib/openstack/test_os_contexts.py'
34--- tests/contrib/openstack/test_os_contexts.py 2015-02-03 21:01:32 +0000
35+++ tests/contrib/openstack/test_os_contexts.py 2015-02-24 11:28:04 +0000
36@@ -1940,10 +1940,11 @@
37 self.is_relation_made.return_value = True
38 self.relation_ids.return_value = ['zeromq-configuration:1']
39 self.related_units.return_value = ['openstack-zeromq/0']
40- self.relation_get.side_effect = ['nonce-data', 'hostname']
41+ self.relation_get.side_effect = ['nonce-data', 'hostname', 'redis']
42 self.assertEquals(context.ZeroMQContext()(),
43 {'zmq_host': 'hostname',
44- 'zmq_nonce': 'nonce-data'})
45+ 'zmq_nonce': 'nonce-data',
46+ 'zmq_redis_address': 'redis'})
47
48 def test_notificationdriver_context_nomsg(self):
49 relations = {

Subscribers

People subscribed via source and target branches