ae894f6...
by
OpenDev Sysadmins <email address hidden>
OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:
Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
ceph-osd<->nrpe relation adds a single check that parses the service
status of all the ceph-osd processes. The check supported sysv and
upstart environments, but not systemd, which has been added.
add_init_service_checks does support systemd but it would create a
nrpe check per OSD (vs a single check for all OSDs)
Ensure that device paths provided by end users are used for OSD's,
rather than the link target device as this may change between
reboots. The specific use case is bcache, where:
/dev/bcacheX:
changes between reboots
/dev/disk/by-dname/bcacheX:
udev managed and consistent
This change also ensures that any unit data is updated to switch
back to using the provided block device path, rather than the
actual target which may have been used in prior charm revisions.
Ensure that udev rules are not installed and reloaded
when running in a container; this is not permitted and
the udev rules are used for block devices, which are
not supported within container based deployments.
Change-Id: I9a580172fcbbf8cec63af7adccb0808915184658
Closes-Bug: 1776713
(cherry picked from commit dd426903471f28eff8e357bac2ca0889ffcff4b9)
Similar to how osdize in charms.ceph checks for already processed
devices we need to avoid checking if they are pristine or not.
Additionally, mapped LUKS devices need to be filtered from being zapped
as they may hold valuable data. They are only used as underlying devices
for device mapper and dmcrypt to provide a decrypted block device
abstration so if they really need to be zapped a mapping needs to be
removed first.
add-disk: Ensure key-manager config is passed to osdize
Recent changes to support vault for key management require that
the 'osd-encrypt-keymanager' is passed to all osdize calls so
that the correct key management approach is taken.
Ensure that the add-disk action does the same, otherwise keys
will always be stored in the ceph mon KV store, rather than
in Vault.
Closes-Bug: 1780920
Change-Id: I8c722d38d68f13dc00c7444a50d67ce37fbd6a29
(cherry picked from commit 6c27240761862ebceac05b979b36b2b713ca1b90)
Commit 352d6993870be2547f37463e4e3cffc7605f749c introduced a change
in assess_status to not update status as long as the previous status
was 'blocked'. This was done because the check for pristine block
devices is done elsewhere in the charm.
However there are other situations that might set the charm in
'blocked' state.
