Pull changes over for scanning (#218)
* Fix uninitialized member variable (Coverity)
Found by Coverity Scan
CID: 291841
* Remove unused member variable (Coverity)
Remove unused member variable that was causing uninitialized member
pointer field defect in Coverity Scan
CID: 365090
* Fix uninitialized member varaibles (Coverity)
Fix uninitialized member variable defects from Coverity Scan
CID: 365091
CID: 365095
* Replace usage of rand() with modern alternative (Coverity)
Eliminates warning about use of unsafe rand() function. Not really
necessary, since this was just randomizing a playlist and not crypto
related, but wanted to silence the warning.
CID: 365092
* Initialize media backends as nullptr on construction (Coverity)
Should silence the uninitilized members warning from Coverity Scan.
These will always be set before use but can't be in the constructor
since this class is used in a ui file.
CID: 365093
* Initialize member gst element pointers to nullptr on construction
(Coverity)
These don't get initialized for real or used until a song is actually
previewed. Not initialized on construction because they'll be different
depending on whether it's a cdg or video file.
CID: 365094
* Fix resource leak in karaoke song name editor (Coverity)
Fix leaked pointer in song name editor and clean up totally unneeded
pointer stuff in sourcedirtablemodel. Relic from when I didn't
understand how and why to use pointers, heh.
CID: 365096
* Remove unused VideoDisplayAR class
Had a bug caught by coverity, but the code wasn't being used anymore so
I just removed it completely.
CID: 365097
* Coverity scan (#215)
* Work on automated travis-ci based coverity scan
* Use modern std::shuffle instead of std::random_shuffle
* Add back autoAudioSrc. Was actually in use on Windows builds.
* Fix file descriptor leak
Co-authored-by: T. Isaac Lightburn <email address hidden>
Pull in fixes for testing with scanner (#217)
* Fix uninitialized member variable (Coverity)
Found by Coverity Scan
CID: 291841
* Remove unused member variable (Coverity)
Remove unused member variable that was causing uninitialized member
pointer field defect in Coverity Scan
CID: 365090
* Fix uninitialized member varaibles (Coverity)
Fix uninitialized member variable defects from Coverity Scan
CID: 365091
CID: 365095
* Replace usage of rand() with modern alternative (Coverity)
Eliminates warning about use of unsafe rand() function. Not really
necessary, since this was just randomizing a playlist and not crypto
related, but wanted to silence the warning.
CID: 365092
* Initialize media backends as nullptr on construction (Coverity)
Should silence the uninitilized members warning from Coverity Scan.
These will always be set before use but can't be in the constructor
since this class is used in a ui file.
CID: 365093
* Initialize member gst element pointers to nullptr on construction
(Coverity)
These don't get initialized for real or used until a song is actually
previewed. Not initialized on construction because they'll be different
depending on whether it's a cdg or video file.
CID: 365094
* Fix resource leak in karaoke song name editor (Coverity)
Fix leaked pointer in song name editor and clean up totally unneeded
pointer stuff in sourcedirtablemodel. Relic from when I didn't
understand how and why to use pointers, heh.
CID: 365096
* Remove unused VideoDisplayAR class
Had a bug caught by coverity, but the code wasn't being used anymore so
I just removed it completely.
CID: 365097
* Coverity scan (#215)
* Work on automated travis-ci based coverity scan
* Use modern std::shuffle instead of std::random_shuffle
Co-authored-by: T. Isaac Lightburn <email address hidden>
