Merge lp:~openerp/openobject-server/property_attribute into lp:openobject-server

Proposed by Husen Daudi
Status: Rejected
Rejected by: Olivier Dony (Odoo)
Proposed branch: lp:~openerp/openobject-server/property_attribute
Merge into: lp:openobject-server
Diff against target: 11 lines (+1/-0)
1 file modified
bin/addons/base/rng/view.rng (+1/-0)
To merge this branch: bzr merge lp:~openerp/openobject-server/property_attribute
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Disapprove
Review via email: mp+45325@code.launchpad.net

This proposal supersedes a proposal from 2010-11-18.

Description of the change

Branch to add property attribute on chat field like.

<field name="name" property="upper"/>
<field name="name" property="lower"/>
<field name="name" property="numeric"/>

so that widget will accept only upper/lower or numeric values.

this feature need following merge tobe done on gtk too.

https://code.launchpad.net/~openerp/openobject-client/property_attribute/+merge/41148

To post a comment you must log in.
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

We can't consider merging this for 6.0, see the explanation on the client-side merge proposal which contains the bulk of this feature: https://code.launchpad.net/~openerp/openobject-client/property_attribute/+merge/41148

review: Disapprove
Revision history for this message
xrg (xrg) wrote :

On Thursday 06 January 2011, you wrote:
> hda (OpenERP) has proposed merging
> lp:~openerp/openobject-server/property_attribute into
> lp:openobject-server.
> ...
> so that widget will accept only upper/lower or numeric values.
> this feature need following merge tobe done on gtk too.

It is forward and harmless, ++

But, Please, don't release only a web-client against that. Make sure it's
implemented in Gtk, too, at the same release.

(If Gtk doesn't support it, I mean, we should /not/ release the feature only
for v6.0.0 web-client)

Unmerged revisions

3027. By husen <husen@husen-laptop>

added property attribute in grammer

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/addons/base/rng/view.rng'
2--- bin/addons/base/rng/view.rng 2010-12-27 10:41:55 +0000
3+++ bin/addons/base/rng/view.rng 2011-01-06 05:28:58 +0000
4@@ -412,6 +412,7 @@
5 <rng:attribute name="name" />
6 <rng:ref name="overload"/>
7 <rng:ref name="access_rights"/>
8+ <rng:optional><rng:attribute name="property"/></rng:optional>
9 <rng:optional><rng:attribute name="editable"/></rng:optional>
10 <rng:optional><rng:attribute name="domain_filter"/></rng:optional>
11 <rng:optional><rng:attribute name="attrs"/></rng:optional>