Merge lp:~openerp-groupes/openobject-server/6.0-fix-setup-windows into lp:openobject-server/6.0

Proposed by Olivier Ligot
Status: Rejected
Rejected by: Xavier ALT
Proposed branch: lp:~openerp-groupes/openobject-server/6.0-fix-setup-windows
Merge into: lp:openobject-server/6.0
Diff against target: 19 lines (+4/-4)
1 file modified
setup.py (+4/-4)
To merge this branch: bzr merge lp:~openerp-groupes/openobject-server/6.0-fix-setup-windows
Reviewer Review Type Date Requested Status
Xavier ALT (community) Disapprove
Review via email: mp+60056@code.launchpad.net

Description of the change

This branch removes unnecessary packages from setup.py
This allows to package OpenERP server on Windows.

To post a comment you must log in.
Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi,

I'm going to reject this MP, because those dependencies should not be removed, as they are dependencies of official and extra addons (base_calendar, document_webdav, olap and etl modules for example). For the two first, this will prevent them to work normally when packaged within the all-in-one.

Regards,
Xavier

review: Disapprove

Unmerged revisions

3420. By Olivier Ligot

[REM] Setup: remove unnecessary packages

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2011-03-30 17:04:32 +0000
3+++ setup.py 2011-05-05 12:45:59 +0000
4@@ -53,11 +53,11 @@
5 "dist_dir": 'dist',
6 "packages": [
7 "lxml", "lxml.builder", "lxml._elementpath", "lxml.etree",
8- "lxml.objectify", "decimal", "xml", "xml", "xml.dom", "xml.xpath",
9- "encodings", "dateutil", "wizard", "pychart", "PIL", "pyparsing",
10- "pydot", "asyncore","asynchat", "reportlab", "vobject",
11+ "lxml.objectify", "decimal", "xml", "xml", "xml.dom",
12+ "encodings", "dateutil", "wizard", "pychart", "PIL",
13+ "pydot", "asyncore","asynchat", "reportlab",
14 "HTMLParser", "select", "mako", "poplib",
15- "imaplib", "smtplib", "email", "yaml", "DAV",
16+ "imaplib", "smtplib", "email", "yaml",
17 "uuid", "commands",
18 ],
19 "excludes" : ["Tkconstants","Tkinter","tcl"],