Merge lp:~openerp-dev/openobject-server/trunk-remove-nodestroy-rga into lp:openobject-server

Proposed by Ravi Gadhia (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-server/trunk-remove-nodestroy-rga
Merge into: lp:openobject-server
Diff against target: 35 lines (+0/-3)
3 files modified
openerp/addons/base/ir/ir_actions.py (+0/-1)
openerp/addons/base/module/module.py (+0/-1)
openerp/addons/base/res/res_config.py (+0/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/trunk-remove-nodestroy-rga
Reviewer Review Type Date Requested Status
Olivier Dony (Odoo) Pending
Review via email: mp+168959@code.launchpad.net

Description of the change

Remove GTK client specific attribute 'nodestroy'

'nodestroy' was introduce for stop crashing GTK client when form view button(type object) return action. if we not return 'nodestroy':True in action it will crash client for osv object but web client gracefully handle it

To post a comment you must log in.

Unmerged revisions

4898. By RGA(OpenERP)

Remove GTK client specific attribute 'nodestroy'

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/ir/ir_actions.py'
2--- openerp/addons/base/ir/ir_actions.py 2013-04-29 07:29:38 +0000
3+++ openerp/addons/base/ir/ir_actions.py 2013-06-12 14:04:26 +0000
4@@ -846,7 +846,6 @@
5 if act_type['type'] != 'ir.actions.act_window':
6 return res
7 res.setdefault('context','{}')
8- res['nodestroy'] = True
9
10 # Open a specific record when res_id is provided in the context
11 user = self.pool.get('res.users').browse(cr, uid, uid, context=context)
12
13=== modified file 'openerp/addons/base/module/module.py'
14--- openerp/addons/base/module/module.py 2013-04-22 09:36:55 +0000
15+++ openerp/addons/base/module/module.py 2013-06-12 14:04:26 +0000
16@@ -53,7 +53,6 @@
17 'res_model': 'base.module.upgrade',
18 'target': 'new',
19 'type': 'ir.actions.act_window',
20- 'nodestroy': True,
21 }
22
23 def backup(path, raise_exception=True):
24
25=== modified file 'openerp/addons/base/res/res_config.py'
26--- openerp/addons/base/res/res_config.py 2013-05-08 15:32:07 +0000
27+++ openerp/addons/base/res/res_config.py 2013-06-12 14:04:26 +0000
28@@ -100,7 +100,6 @@
29 _logger.info('next action is %s', next)
30 if next:
31 res = next.action_launch(context=context)
32- res['nodestroy'] = False
33 return res
34 # reload the client; open the first available root menu
35 menu_obj = self.pool['ir.ui.menu']