Merge lp:~openerp-dev/openobject-server/trunk-remove-menu_id-from-user-rma into lp:openobject-server

Proposed by Randhir Mayatra (OpenERP)
Status: Merged
Approved by: Richard Mathot (Odoo, formerly OpenERP)
Approved revision: 5114
Merged at revision: 5198
Proposed branch: lp:~openerp-dev/openobject-server/trunk-remove-menu_id-from-user-rma
Merge into: lp:openobject-server
Diff against target: 78 lines (+1/-24)
3 files modified
openerp/addons/base/base_data.xml (+0/-10)
openerp/addons/base/res/res_users.py (+1/-13)
openerp/addons/base/res/res_users_view.xml (+0/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/trunk-remove-menu_id-from-user-rma
Reviewer Review Type Date Requested Status
Richard Mathot (Odoo, formerly OpenERP) (community) Approve
Vidhin Mehta (OpenERP) (community) Needs Resubmitting
Review via email: mp+215638@code.launchpad.net

Description of the change

Hello,
   -- remove menu_id field from user model
      -- removed label 'Menu Customization', Home Action and Menu Action Fields from setting->users->preferences.

Thanks..

Randhir Mayatra(RMA)

To post a comment you must log in.
5109. By Randhir Mayatra (OpenERP)

[IMP] remove 'action_menu_admin' record, because its not required anymore

5110. By Randhir Mayatra (OpenERP)

[MERGE] merge with latest trunk

5111. By Vidhin Mehta (OpenERP)

[IMP]add action_id

5112. By Vidhin Mehta (OpenERP)

[IMP]indent

5113. By Vidhin Mehta (OpenERP)

[IMP]

Revision history for this message
Vidhin Mehta (OpenERP) (vme-openerp) :
review: Needs Resubmitting
Revision history for this message
Richard Mathot (Odoo, formerly OpenERP) (rim-openerp) wrote :

LGTM

review: Approve
5114. By Richard Mathot (Odoo, formerly OpenERP)

[FIX] Dirty revert

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/base_data.xml'
2--- openerp/addons/base/base_data.xml 2014-01-30 09:31:09 +0000
3+++ openerp/addons/base/base_data.xml 2014-04-29 13:52:26 +0000
4@@ -11,15 +11,6 @@
5 </field>
6 <field name="field_parent">child_id</field>
7 </record>
8- <record id="action_menu_admin" model="ir.actions.act_window">
9- <field name="name">Menu</field>
10- <field name="usage">menu</field>
11- <field name="type">ir.actions.act_window</field>
12- <field name="view_id" ref="view_menu"/>
13- <field name="res_model">ir.ui.menu</field>
14- <field name="view_type">tree</field>
15- <field name="domain">[('parent_id', '=', False)]</field>
16- </record>
17
18 <record id="lang_en" model="res.lang">
19 <field name="code">en_US</field>
20@@ -75,7 +66,6 @@
21 <field name="partner_id" ref="base.partner_root"/>
22 <field name="company_id" ref="main_company"/>
23 <field name="company_ids" eval="[(4, ref('main_company'))]"/>
24- <field name="menu_id" ref="action_menu_admin"/>
25 <field name="signature">--
26 Administrator</field>
27 </record>
28
29=== modified file 'openerp/addons/base/res/res_users.py'
30--- openerp/addons/base/res/res_users.py 2014-04-09 10:33:37 +0000
31+++ openerp/addons/base/res/res_users.py 2014-04-29 13:52:26 +0000
32@@ -154,8 +154,7 @@
33 "a change of password, the user has to login again."),
34 'signature': fields.text('Signature'),
35 'active': fields.boolean('Active'),
36- 'action_id': fields.many2one('ir.actions.actions', 'Home Action', help="If specified, this action will be opened at logon for this user, in addition to the standard menu."),
37- 'menu_id': fields.many2one('ir.actions.actions', 'Menu Action', help="If specified, the action will replace the standard menu for this user."),
38+ 'action_id': fields.many2one('ir.actions.actions', 'Home Action', help="If specified, this action will be opened at log on for this user, in addition to the standard menu."),
39 'groups_id': fields.many2many('res.groups', 'res_groups_users_rel', 'uid', 'gid', 'Groups'),
40 # Special behavior for this field: res.company.search() will only return the companies
41 # available to the current user (should be the user's companies?), when the user_preference
42@@ -217,16 +216,6 @@
43 return [c]
44 return False
45
46- def _get_menu(self,cr, uid, context=None):
47- dataobj = self.pool.get('ir.model.data')
48- try:
49- model, res_id = dataobj.get_object_reference(cr, uid, 'base', 'action_menu_admin')
50- if model != 'ir.actions.act_window':
51- return False
52- return res_id
53- except ValueError:
54- return False
55-
56 def _get_group(self,cr, uid, context=None):
57 dataobj = self.pool.get('ir.model.data')
58 result = []
59@@ -244,7 +233,6 @@
60 'password': '',
61 'active': True,
62 'customer': False,
63- 'menu_id': _get_menu,
64 'company_id': _get_company,
65 'company_ids': _get_companies,
66 'groups_id': _get_group,
67
68=== modified file 'openerp/addons/base/res/res_users_view.xml'
69--- openerp/addons/base/res/res_users_view.xml 2014-03-04 17:52:31 +0000
70+++ openerp/addons/base/res/res_users_view.xml 2014-04-29 13:52:26 +0000
71@@ -201,7 +201,6 @@
72 </group>
73 <group string="Menus Customization" groups="base.group_no_one">
74 <field name="action_id"/>
75- <field domain="[('usage','=','menu')]" name="menu_id" required="True"/>
76 </group>
77 </group>
78 <group string="Messaging and Social" name="messaging">