Merge lp:~openerp-dev/openobject-server/trunk-import-fixes-xmo into lp:openobject-server
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Antony Lesuisse (OpenERP) | ||||
Proposed branch: | lp:~openerp-dev/openobject-server/trunk-import-fixes-xmo | ||||
Merge into: | lp:openobject-server | ||||
Diff against target: |
389 lines (+269/-38) 2 files modified
openerp/osv/orm.py (+62/-38) openerp/tests/test_import.py (+207/-0) |
||||
To merge this branch: | bzr merge lp:~openerp-dev/openobject-server/trunk-import-fixes-xmo | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aline (OpenERP) | Pending | ||
OpenERP Core Team | Pending | ||
Review via email: mp+84447@code.launchpad.net |
Description of the change
Fixes to import_data:
* Added some tests to check behavior
* Improved doc and naming
* Fixed handling of non-id o2m subfields not preceded by an id-type field for the same o2m (would get treated as "names" and blow up if "name_search" call failed)
Unmerged revisions
- 3853. By Xavier (Open ERP)
-
[MERGE] from trunk
- 3852. By Xavier (Open ERP)
-
[ADD] documentary note about one of the probably numerous UBs in import_data
- 3851. By Xavier (Open ERP)
-
[FIX] special case for handling o2m fields without sub-fields
- 3850. By Xavier (Open ERP)
-
[ADD] test of updating an existing o2m (linked by db id)
- 3849. By Xavier (Open ERP)
-
[IMP] clarify process_liness code for o2m
- 3848. By Xavier (Open ERP)
-
[ADD] o2m import testing, from empty db, fix code which blows up in that case
- 3847. By Xavier (Open ERP)
-
[ADD] basics for correctly testing import
- 3846. By Xavier (Open ERP)
-
[MERGE] trunk improvements
- 3845. By Xavier (Open ERP)
-
[REM] redundant check (that line[i] be non-empty is checked at the start of the iteration)
also moved res assignment (to a falsy value) closer to where it's actually needed
- 3844. By Xavier (Open ERP)
-
[FIX] variable naming
datas is a brazilian municipality, not an english word