Merge lp:~openerp-dev/openobject-server/trunk-imp-warning-msg-bde into lp:openobject-server

[Bharat Devnani (Open ERP)]

Hello Sir,

I have improved warning message as per specification.

Thanks & Regards,
Devnani Bharat R.

[lp:~openerp-dev/openobject-server/trunk-imp-warning-msg-bde]

5006. By Bharat Devnani (Open ERP) on 2013-12-02

[IMP] improved the code

5007. By Bharat Devnani (Open ERP) on 2013-12-02

[IMP] improved the code

5008. By Bharat Devnani (Open ERP) on 2013-12-03

[IMP] improved the code

5009. By Bharat Devnani (Open ERP) on 2013-12-31

[MERGE] merged with latest server branch

5010. By Bharat Devnani (Open ERP) on 2014-02-12

[MERGE] merged with latest server

5011. By Bharat Devnani (Open ERP) on 2014-02-12

[IMP] improved

5012. By Bharat Devnani (Open ERP) on 2014-02-12

[IMP] improved

5013. By Bharat Devnani (Open ERP) on 2014-02-12

[IMP] improved the code to get the name of currency instead of id

5014. By Bharat Devnani (Open ERP) on 2014-04-18

[MERGE] merged with main server branch

[Richard Mathot (Odoo, formerly OpenERP) (rim-openerp)]

Please move the "browse" operation to the else clause, in order to avoid some unnecessary "browse"

review: Needs Fixing

[lp:~openerp-dev/openobject-server/trunk-imp-warning-msg-bde]

5015. By Richard Mathot (Odoo, formerly OpenERP) on 2014-04-23

[FIX] res_currency: Removing unnecessary 'browse'

[Richard Mathot (Odoo, formerly OpenERP) (rim-openerp)]

Fixed, LGTM

review: Approve

=== modified file 'openerp/addons/base/res/res_currency.py'
--- openerp/addons/base/res/res_currency.py	2013-11-15 13:25:53 +0000
+++ openerp/addons/base/res/res_currency.py	2014-04-23 07:35:49 +0000
@@ -58,7 +58,8 @@
             elif not raise_on_no_rate:
                 res[id] = 0
             else:
-                raise osv.except_osv(_('Error!'),_("No currency rate associated for currency %d for the given period" % (id)))
+                currency = self.browse(cr, uid, id, context=context)
+                raise osv.except_osv(_('Error!'),_("No currency rate associated for currency '%s' for the given period" % (currency.name)))
         return res
 
     _name = "res.currency"