Merge lp:~openerp-dev/openobject-server/trunk-imp-readonly-field-dka into lp:openobject-server

[Darshan Kalola(OpenERP)]

Unmerged revisions

5193. By Darshan Kalola(OpenERP) on 2014-04-22

[IMP]orm : update write method to check field is readonly, if its readonly then raise error message 'you can not change the value of readonly field', checked readonly field base on states.

=== modified file 'openerp/osv/orm.py'
--- openerp/osv/orm.py	2014-04-16 14:34:31 +0000
+++ openerp/osv/orm.py	2014-04-22 11:54:15 +0000
@@ -3767,6 +3767,18 @@
 
         return True
 
+    def compute_domain(self, cr, user, ids, domain, context=None): 
+        state = ''
+        readonly = False
+        for obj in self.browse(cr, user, ids, context=context):
+            if hasattr(obj,'state'):
+                state = obj.state
+        if domain[1] == 'not in':
+            if state not in domain[2]: readonly = True
+        if domain[1] == 'in':
+            if state in domain[2]: readonly = True
+        return readonly
+
     #
     # TODO: Validate
     #
@@ -3830,6 +3842,28 @@
                 continue
             groups = fobj.write
 
+            state_exception = []
+            res = []
+            default_value = None
+            if field in self._columns:
+                fields = self._columns[field]
+                if hasattr(fields, 'readonly'):
+                    default_value = self._columns[field].readonly 
+                if hasattr(fields, 'states'):
+                    states = self._columns[field].states 
+                    for state, expr in states.items():
+                        if expr[0][0] == 'readonly':
+                            if expr[0][1] != default_value:
+                                state_exception.append(state)
+                            if expr[0][1] == False:
+                                res = ['state','not in', state_exception]
+                            else:
+                                res = ['state','in', state_exception]
+                    if len(res) > 0:
+                        if self.compute_domain(cr, user, ids, res, context=context):
+                            raise except_orm(_('Error'),
+                                             _('You can not change the value of readonly field (%s).') % field)
+
             if groups:
                 edit = False
                 for group in groups: