Merge lp:~openerp-dev/openobject-server/trunk-function-getter-assertion-cto into lp:openobject-server

[Samus CTO (OpenERP)]

Hello odo,

I made the improvement we talked a long ago.

There is finally 2 checks:
 - one to check if some ids are missing in the result
 - one to check if there is not too many ids

Maybe it is better to put a warning in the second case? I don't think so (because it permit less optimized codes).

Let me know if this improvement is correct or not.

Unmerged revisions

4876. By Samus CTO (OpenERP) on 2013-05-23

[IMP] Getter method of function field now check if all requested ids are present in the result

=== modified file 'openerp/osv/fields.py'
--- openerp/osv/fields.py	2013-03-29 14:07:23 +0000
+++ openerp/osv/fields.py	2013-05-24 13:37:36 +0000
@@ -1130,6 +1130,8 @@
 
     def get(self, cr, obj, ids, name, uid=False, context=None, values=None):
         result = self._fnct(obj, cr, uid, ids, name, self._arg, context)
+        assert set(ids) - set(result.keys()) == set(), "The function field %s of object %s didn't return a dict with all the requested values for ids: %s!" % (name, obj._name, ids)
+        assert set(ids) == set(result.keys()), "The function field %s of object %s returned too much values when requested these ids: %s!" % (name, obj._name, ids)
         for id in ids:
             if self._multi and id in result:
                 for field, value in result[id].iteritems():