Merge lp:~openerp-dev/openobject-server/trunk-bug-1065988-aja into lp:openobject-server

Proposed by ajay javiya (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-server/trunk-bug-1065988-aja
Merge into: lp:openobject-server
Diff against target: 62 lines (+10/-6)
3 files modified
openerp/addons/base/module/module.py (+6/-4)
openerp/addons/base/module/wizard/base_module_update.py (+3/-2)
openerp/addons/base/module/wizard/base_module_update_view.xml (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/trunk-bug-1065988-aja
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+129886@code.launchpad.net

Description of the change

Hello,
Remove module from module list, after deleting the module from the addons folder and updating the module list.
Thank You

To post a comment you must log in.

Unmerged revisions

4493. By ajay javiya (OpenERP)

[FIX]:Remove Modules in Module update list

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/module/module.py'
2--- openerp/addons/base/module/module.py 2012-10-03 16:18:07 +0000
3+++ openerp/addons/base/module/module.py 2012-10-16 13:25:04 +0000
4@@ -516,17 +516,19 @@
5
6 # update the list of available packages
7 def update_list(self, cr, uid, context=None):
8- res = [0, 0] # [update, add]
9-
10+ res = [0, 0, 0] # [update, add, delete]
11 known_mods = self.browse(cr, uid, self.search(cr, uid, []))
12 known_mods_names = dict([(m.name, m) for m in known_mods])
13-
14+
15+ module_deleted = list(set(known_mods_names.keys()) - set(modules.get_modules()))
16+ module_ids=self.search(cr,uid,[('name','in',module_deleted),('state','=','uninstalled')])
17+ self.unlink(cr,uid,module_ids)
18+ res[2] = len(module_deleted)
19 # iterate through detected modules and update/create them in db
20 for mod_name in modules.get_modules():
21 mod = known_mods_names.get(mod_name)
22 terp = self.get_module_info(mod_name)
23 values = self.get_values_from_terp(terp)
24-
25 if mod:
26 updated_values = {}
27 for key in values:
28
29=== modified file 'openerp/addons/base/module/wizard/base_module_update.py'
30--- openerp/addons/base/module/wizard/base_module_update.py 2012-09-28 12:22:06 +0000
31+++ openerp/addons/base/module/wizard/base_module_update.py 2012-10-16 13:25:04 +0000
32@@ -29,6 +29,7 @@
33 _columns = {
34 'update': fields.integer('Number of modules updated', readonly=True),
35 'add': fields.integer('Number of modules added', readonly=True),
36+ 'delete':fields.integer('Number of modules deleted', readonly=True),
37 'state':fields.selection([('init','init'),('done','done')], 'state', readonly=True),
38 }
39
40@@ -38,8 +39,8 @@
41
42 def update_module(self, cr, uid, ids, context=None):
43 module_obj = self.pool.get('ir.module.module')
44- update, add = module_obj.update_list(cr, uid,)
45- self.write(cr, uid, ids, {'update': update, 'add': add, 'state': 'done'}, context=context)
46+ update, add, delete = module_obj.update_list(cr, uid,)
47+ self.write(cr, uid, ids, {'update': update, 'add': add,'delete': delete, 'state': 'done'}, context=context)
48 return False
49
50 def action_module_open(self, cr, uid, ids, context):
51
52=== modified file 'openerp/addons/base/module/wizard/base_module_update_view.xml'
53--- openerp/addons/base/module/wizard/base_module_update_view.xml 2012-08-17 07:25:55 +0000
54+++ openerp/addons/base/module/wizard/base_module_update_view.xml 2012-10-16 13:25:04 +0000
55@@ -15,6 +15,7 @@
56 <group states="done" >
57 <field name="update"/>
58 <field name="add" />
59+ <field name="delete" />
60 </group>
61 <footer>
62 <div states="init">