Merge lp:~openerp-dev/openobject-server/trunk-bug-1044341-tta into lp:openobject-server

[SnippetBucket.com]

Hello,

Fixed Bug: 1044341

 * Fixed ORM Search Method not works with Order by create_date, write_date, create_uid, write_uid, id.

 * With trunk only id is able to make order by, in search method other magic columns are not works.
   Here this fix will works with id and all other magic columns too. Now its possible to do "write_date desc" or "id desc".

 * Reported Bug: https://bugs.launchpad.net/openobject-server/+bug/1044341

Thanks,
tta

[Vo Minh Thu (thu)]

Seems to be fixed in trunk at revision 4743.1.205. Thanks.

Unmerged revisions

4850. By SnippetBucket.com on 2013-04-04

[FIX] ORM Search method now able to make order by with MEGIC_COLUMNs too. MAGIC_COLUMNS = id, create_date, write_date, create_uid, write_uid.

=== modified file 'openerp/osv/orm.py'
--- openerp/osv/orm.py	2013-03-25 14:32:56 +0000
+++ openerp/osv/orm.py	2013-04-04 09:52:28 +0000
@@ -4811,8 +4811,8 @@
                 order_field = order_split[0].strip()
                 order_direction = order_split[1].strip() if len(order_split) == 2 else ''
                 inner_clause = None
-                if order_field == 'id':
-                    order_by_elements.append('"%s"."id" %s' % (self._table, order_direction))
+                if order_field in MAGIC_COLUMNS:
+                    order_by_elements.append('"%s"."%s" %s' % (self._table, order_field, order_direction))
                 elif order_field in self._columns:
                     order_column = self._columns[order_field]
                     if order_column._classic_read: