Thanks for the review. I will check what you said properly, but quickly my first thoughts:
It seems you're right it is a bad idea to store registry-specific data in sys.modules :)
I'm not sure I could memoize them. I think I re-run them as each module is installed.
The other "orthogonal" stuff: I'm not they are that much orthogonal. I'm pretty sure some of them were possible because of the main change of this merge prop, and some other were actually necessary. I don't want to play with three branches (the orthogonal stuff that are not necessary for this branch, those that depends on this branch, and this branch) and re-base all the resulting commits.
Thanks for the review. I will check what you said properly, but quickly my first thoughts:
It seems you're right it is a bad idea to store registry-specific data in sys.modules :)
I'm not sure I could memoize them. I think I re-run them as each module is installed.
The other "orthogonal" stuff: I'm not they are that much orthogonal. I'm pretty sure some of them were possible because of the main change of this merge prop, and some other were actually necessary. I don't want to play with three branches (the orthogonal stuff that are not necessary for this branch, those that depends on this branch, and this branch) and re-base all the resulting commits.