Merge lp:~openerp-dev/openobject-server/trunk-addons21-nco into lp:openobject-server

Proposed by Nimesh Contractor(Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-server/trunk-addons21-nco
Merge into: lp:openobject-server
Diff against target: 16 lines (+6/-0)
1 file modified
openerp/service/web_services.py (+6/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/trunk-addons21-nco
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+137538@code.launchpad.net

Description of the change

Hello,

      Fix the trace-back when creating a database with a name that already exists.
      Make create button invisible on module tree view.

Thanks,
Nimesh.

To post a comment you must log in.

Unmerged revisions

4599. By Nimesh Contractor(Open ERP)

[MERGE] merge with lp:openobject-server

4598. By Nimesh Contractor(Open ERP)

[MERGE] merge with lp:openobject-server

4597. By Atul Patel(OpenERP)

[MERGE]: Merged with lp:openobject-server

4596. By Nimesh Contractor(Open ERP)

[MERGE] lp:openobject-server

4595. By Nimesh Contractor(Open ERP)

[MERGE] merged lp:~openerp-dev/openobject-server/trunk-addons21-settings-pja

4594. By Nimesh Contractor(Open ERP)

[MERGE] merge lp:~openerp-dev/openobject-server/trunk-addons21-general-dbname-pja

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/service/web_services.py'
2--- openerp/service/web_services.py 2012-11-29 11:43:02 +0000
3+++ openerp/service/web_services.py 2012-12-03 11:48:23 +0000
4@@ -120,6 +120,12 @@
5 db = sql_db.db_connect('postgres')
6 cr = db.cursor()
7 chosen_template = tools.config['db_template']
8+ cr.execute("""SELECT datname
9+ FROM pg_database
10+ WHERE datname = %s """,
11+ (name,))
12+ if cr.fetchall():
13+ raise openerp.exceptions.Warning(" %s database already exists!" % name )
14 try:
15 cr.autocommit(True) # avoid transaction block
16 cr.execute("""CREATE DATABASE "%s" ENCODING 'unicode' TEMPLATE "%s" """ % (name, chosen_template))