Merge lp:~openerp-dev/openobject-server/7.0-tz-order-change-csn into lp:openobject-server/7.0

[Olivier Dony (Odoo)]

Fix for bug 1086728: move "Etc/*" timezone entries at the end of the list to avoid confusing users. See the discussion on bug 1086728.

[Olivier Dony (Odoo) (odo-openerp)]

@Cedric: Functionally it looks good to me, but technically I think the implementation should be shortened by using the Python API properly. Please use the functional programming aspects of Python as much as possible, it makes the code shorter, more readable, and is much less error-prone (more procedural code such as loops, assignations, etc. means more chances of introducing bugs!)

This patch could basically be a 2-liner, by using a simple sorting function that replaces "Etc/*" by "_" so it is sorted last alphabetically.

    # put POSIX 'Etc/*' entries at the end to avoid confusing users - see bug 1086728
    return [(tz,tz) for tz in sorted(pytz.all_timezones, key=lambda tz: tz if not tz.startswith('Etc/') else '_')]

For reference:
- Sorting Python lists: http://wiki.python.org/moin/HowTo/Sorting/#Key_Functions
- Python functional programming: http://docs.python.org/2/howto/functional.html

review: Needs Fixing

[lp:~openerp-dev/openobject-server/7.0-tz-order-change-csn]

4974. By Cedric Snauwaert (OpenERP) on 2013-05-15

[REF]res_partner: compact code to get tz info

=== modified file 'openerp/addons/base/res/res_partner.py'
--- openerp/addons/base/res/res_partner.py	2013-04-25 17:12:38 +0000
+++ openerp/addons/base/res/res_partner.py	2013-05-15 10:12:27 +0000
@@ -74,7 +74,8 @@
 
 
 def _tz_get(self,cr,uid, context=None):
-    return [(x, x) for x in pytz.all_timezones]
+    # put POSIX 'Etc/*' entries at the end to avoid confusing users - see bug 1086728
+    return [(tz,tz) for tz in sorted(pytz.all_timezones, key=lambda tz: tz if not tz.startswith('Etc/') else '_')]
 
 class res_partner_category(osv.osv):