Code review comment for lp:~openerp-dev/openobject-server/7.0-sequence-next-fix-csn

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Looks good to me except the default value of number_next when passed to _alter_sequence(), that should be None rather than 0, otherwise you're forbidding resetting the sequence to 0, which is perfectly legit.

Note: the patch needs to be credited to Therp, as you reused a large part of their merge prop. We can do that when merging, but please be careful to do that at commit-level directly next time, this is important.

review: Needs Fixing

« Back to merge proposal