Merge lp:~openerp-dev/openobject-server/7.0-sequence-next-fix-csn into lp:openobject-server/7.0
Proposed by
Cedric Snauwaert (OpenERP)
Status: | Merged |
---|---|
Merged at revision: | 4978 |
Proposed branch: | lp:~openerp-dev/openobject-server/7.0-sequence-next-fix-csn |
Merge into: | lp:openobject-server/7.0 |
Diff against target: |
129 lines (+49/-10) 2 files modified
openerp/addons/base/ir/ir_sequence.py (+47/-8) openerp/addons/base/ir/ir_sequence_view.xml (+2/-2) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-server/7.0-sequence-next-fix-csn |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Dony (Odoo) | Approve | ||
qdp (OpenERP) | Pending | ||
Review via email: mp+164363@code.launchpad.net |
Description of the change
Change in ir_sequence to have information on current_number and better warning message in case the format of prefix/suffix isn't correct
To post a comment you must log in.
Looks good to me except the default value of number_next when passed to _alter_sequence(), that should be None rather than 0, otherwise you're forbidding resetting the sequence to 0, which is perfectly legit.
Note: the patch needs to be credited to Therp, as you reused a large part of their merge prop. We can do that when merging, but please be careful to do that at commit-level directly next time, this is important.