Merge lp:~openerp-dev/openobject-server/7.0-perf_imp_wkf_trigger-tfr into lp:openobject-server/7.0

[tfr (Openerp)]

When write is call for more then one ids, the query "SELECT id FROM wkf_instance WHERE res_id = ... AND res_type = '.....' AND state = 'active';" is called for each id in the write.

This is necessary to trigger the workflow but totally unecessary when there is no workflow for the current object.

The patch check the existance of a workflow for the object (1 query) and if there is no workflow do not call trigger_write and thus avoid calling N times the select query on wkf instance.

The improvement is small for a smal amount of records but for 5000 it can multiple the time by 3

Unmerged revisions

5256. By tfr (Openerp) on 2014-03-07

[PERF] Don't try to trigger workflow on write when there is no workflow for the current model, then avoiding unecessary o(n) query on wkf_instance

=== modified file 'openerp/osv/orm.py'
--- openerp/osv/orm.py	2014-03-05 14:30:50 +0000
+++ openerp/osv/orm.py	2014-03-07 13:45:32 +0000
@@ -3983,6 +3983,12 @@
                     returned_ids = [x['id'] for x in cr.dictfetchall()]
                     self._check_record_rules_result_count(cr, uid, sub_ids, returned_ids, operation, context=context)
 
+    def _workflow_check_trigger(self, cr, uid, ids, trigger, context=None):
+        cr.execute('select id from wkf where osv = %s', (self._name,))
+        if cr.fetchone():
+            self._workflow_trigger(cr, uid, ids, trigger, context)
+
+
     def _workflow_trigger(self, cr, uid, ids, trigger, context=None):
         """Call given workflow trigger as a result of a CRUD operation"""
         wf_service = netsvc.LocalService("workflow")
@@ -4341,7 +4347,7 @@
                     todo.append(id)
             self.pool.get(object)._store_set_values(cr, user, todo, fields_to_recompute, context)
 
-        self._workflow_trigger(cr, user, ids, 'trg_write', context=context)
+        self._workflow_check_trigger(cr, user, ids, 'trg_write', context=context)
         return True
 
     #