Merge lp:~openerp-dev/openobject-server/7.0-opw-607398-rgo into lp:openobject-server/7.0

[Ravi Gohil (OpenERP)]

Steps to reproduce issue:
- Install account module,
- Go to "Settings/Configuration/Invoicing" and set "Default Sale Tax"(this tax will be used as default for many2many field "Customer Taxes" when creating a new product),
- Now, go to "Settings/Actions/User-defined Defaults" and change the default value(value in form of the list) for 'taxes_id'("Customer Taxes"),
- Try to create a new product and a same error will be faced as mentioned in lp:1153628,

The cause of the issue is that with each write call to the functional field "value_unpickle", it always dump a string object for a list value(rather then dumping it as a list object) to the field "value".

Wrong value will be dumped for all the fields other than char/selection/text type fields.

This branch fixes this, kindly review it.

Thanks.

[lp:~openerp-dev/openobject-server/7.0-opw-607398-rgo]

5295. By Ravi Gohil (OpenERP) on 2014-05-06

[FIX] Modifying default value for other than char/string/selection fields from 'Setting/Technical/Actions/User-defined Defaults' view sets wrong pickle value for respective record. (Maintenance Case: 607398)

[Martin Trigaux (OpenERP) (mat-openerp)]

Merged in 7.0, thanks

revno: 5295 [merge]
revision-id: <email address hidden>

review: Approve

=== modified file 'openerp/addons/base/ir/ir_values.py'
--- openerp/addons/base/ir/ir_values.py	2013-06-07 09:02:51 +0000
+++ openerp/addons/base/ir/ir_values.py	2014-05-06 06:52:37 +0000
@@ -22,6 +22,7 @@
 
 from openerp.osv import osv, fields
 from openerp.osv.orm import except_orm
+from openerp.tools.safe_eval import safe_eval as eval
 
 EXCLUDED_FIELDS = set((
     'report_sxw_content', 'report_rml_content', 'report_sxw', 'report_rml',
@@ -121,7 +122,10 @@
         record = self.browse(cursor, user, id, context=context)
         if record.key == 'default':
             # default values are pickled on the fly
-            value = pickle.dumps(value)
+            try:
+                value = isinstance(value, (str, unicode)) and pickle.dumps(eval(value)) or pickle.dumps(value)
+            except Exception:
+                value = pickle.dumps(value)
         self.write(cursor, user, id, {name[:-9]: value}, context=ctx)
 
     def onchange_object_id(self, cr, uid, ids, object_id, context=None):