Merge lp:~openerp-dev/openobject-server/7.0-opw-599484-rgo into lp:openobject-server/7.0

Proposed by Ravi Gohil (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-server/7.0-opw-599484-rgo
Merge into: lp:openobject-server/7.0
Diff against target: 23 lines (+5/-2)
1 file modified
openerp/addons/base/res/res_partner_view.xml (+5/-2)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/7.0-opw-599484-rgo
Reviewer Review Type Date Requested Status
Naresh(OpenERP) Pending
Review via email: mp+192682@code.launchpad.net

Description of the change

Hi,

For 'res.partner' object, if 'is_company' is set, the 'title' field is been hidden, I removed this restriction as it was not correct and also corrected the labeling, that is, when 'is_company' is checked, the label of 'title' field is set to 'Partner Firm' and if not checked then it will be set to 'Title'.

This branch will also address the issues mentioned in the branch lp:~openerp-dev/openobject-server/7.0-opw-591029-pna

I also make the 'domain' field visible in 'res.partner.title' object's form view so that the user can choose whom the 'title' belongs when creating it from the 'Sales/Configuration/Address Book/Titles' menu.

Kindly review the fix.

Thanks.

To post a comment you must log in.

Unmerged revisions

5106. By Ravi Gohil (OpenERP)

[FIX] For 'res.partner' object, enabled the visibility of 'title' field when the 'is_company' is set, when creating new record for 'title'(m2o field) from 'res.partner' object set the default value for 'domain'('res.partner.title' object) field based on the 'is_company' field value and changed the label of 'title' field from 'Title' to 'Partner Form' when 'is_company' is checked. (Maintenance Case: 599484)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/res/res_partner_view.xml'
2--- openerp/addons/base/res/res_partner_view.xml 2013-06-07 16:20:45 +0000
3+++ openerp/addons/base/res/res_partner_view.xml 2013-10-25 11:59:23 +0000
4@@ -31,6 +31,7 @@
5 <group col="4">
6 <field name="name"/>
7 <field name="shortcut"/>
8+ <field name="domain"/>
9 </group>
10 </form>
11 </field>
12@@ -179,8 +180,10 @@
13 <field name="mobile"/>
14 <field name="fax"/>
15 <field name="email" widget="email"/>
16- <field name="title" domain="[('domain', '=', 'contact')]"
17- options='{"no_open": True}' attrs="{'invisible': [('is_company','=', True)]}" />
18+ <label for="title" string="Partner Firm" attrs="{'invisible': [('is_company','=',False)]}"/>
19+ <field name="title" domain="[('domain','=','partner')]" options='{"no_open": True}' nolabel="1" attrs="{'invisible': [('is_company','=',False)]}" context="{'default_domain': 'partner'}"/>
20+ <label for="title" string="Title" attrs="{'invisible': [('is_company','=',True)]}"/>
21+ <field name="title" domain="[('domain','=','contact')]" options='{"no_open": True}' nolabel="1" attrs="{'invisible': [('is_company','=',True)]}" context="{'default_domain': 'contact'}"/>
22 </group>
23 </group>
24