Code review comment for lp:~openerp-dev/openobject-server/7.0-fix-contact-company-handling

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote :

Res.partner demo data lacks of TIN / VAT / RIF / RUC / FIN / A.K.A. Fiscal/Tax/Statuary Id Number, so that is triggering The check for uniqueness in TIN.

Could pliz check how did we managed at Openerp-Venezuela-Localization (OVL) to deal with this.

Uniqueness
http://bazaar.launchpad.net/~openerp-venezuela/openerp-venezuela-localization/trunk/view/head:/l10n_ve_fiscal_requirements/model/partner.py#L134

Mandatoriness
http://bazaar.launchpad.net/~openerp-venezuela/openerp-venezuela-localization/trunk/view/head:/l10n_ve_fiscal_requirements/model/partner.py#L170

BTW, if the merge proposal get a go ahead, we ought to refactory this methods, in order to comply
with the new contact-company-management approach, witch by now with this module is broken.

Regards.

« Back to merge proposal