Code review comment for lp:~openerp-dev/openobject-server/7.0-fix-contact-company-handling

Regarding this topic:

>>>>>
* Misc related fixes

- checking `is_company` does not reset the parent_id field anymore, to allow for multi-level structures. The field is still hidden automatically because having an empty "Company" field on the form view of a company is quite suprising), but this UI behavior is easily customized;
>>>>>

IMHO this is correct, but we have an useability problem here. See the vide with explanation, but basically, onw time you set the parent_id <> False it shouldn't be invisible, it should be readonly I think.

I other case.

Understanding deeply your approach.

I think it is incomplete just that.

We have some options.

Res Partner is his own Own Invoice contact [As QuickBook Does]
Childs are contacts. [Simple Contact as we had in V6.1, and for all the extra features we have CRM may be.]

Childs are contact with address type (invoice) and is_company = True. [Subsidiaries Multi address feature we had in V6.1. with a better approach, we can not hide the parent_id if it is setted, because the concept of subsidiary will be this, and the _commercial_id_compute should consider that the parent give the commercial information (But the partner Id will be this one)]

Childs are Company itself. [Parent Child relate we had in V6.1]

I think if we improve this concepts we cover a bigger expectrum as V6.1 did.

IOH, I continue thinking we need the contact_id in documents mandatory, and just hide them for useability issue, the migration should not be difficult, if somebody is using as it is now, when install the module, you can copy the partner_id in the init method, it is easy, may be an extra (but I think it should be in the core of sales , purchase and so on.....

With this, one, we can mantain an onchange with this feature in all places and have recorded the data.