Code review comment for lp:~openerp-dev/openobject-server/7.0-fix-contact-company-handling

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hello,

Thanks for your proposal and your communication around it.

From what I see, it seems to address well most of the issues.

Did you took in account the Raphaël Valyi's concerns?
Raphaël, do you still see theses concerns? Can you give one proper example step-by-step based on this merge proposal please?

We saw a thing which seems to be a remaining bug:
The domain of the partner of an invoice restricts to use only commercial entities (companies), which is fine.
However, when you create a sale order, it does not prevent to use a contact as 'Invoice Address' so the invoice will be created with the contact instead of the company.

On a side note, do you plan to fix lp:1151947 regarding the addresses of customers (b2c) on the bounce while you are at it? :-)

[0] https://lists.launchpad.net/openerp-community/msg02519.html
[1] https://bugs.launchpad.net/openobject-server/+bug/1151947

« Back to merge proposal