Merge lp:~openerp-dev/openobject-server/6.1-opw-578621-rgo into lp:openobject-server/6.1

[Ravi Gohil (OpenERP)]

Hello,

If we run server with option --no-database-list and try to connect to server using GTK-Client and using netrpc, client will show message saying 'Could not connect to server !' and won't allow to connect, but we would be able to do so using xmlrpc.

After investingating the issue, I found that, with --no-database-list option, 'AccessDenied' exception is raised from(server/openerp/service/web_services.py, line#319) and with xmlrpc, it is handled at (server/openerp/wsgi/core.py, line#133) by setting faultCode as 'AccessDenied' which is passed to GTK-Client and GTK-Client handles this faultCode(by checking, if e.faultCode == 'AccessDenied') and returns None.

But in case of netrpc, after raising AccessDenied, a string is returned as 'AccessDenied Access denied.' by server(file server/openerp/service/netrpc_server.py, line#99) and this string will be set as faultCode by GTK-Client(file client/bin/tiny_socket.py, line#108), and this fault code isn't handled by GTK-Client and will not return any thing.

So, on the basis of my above investigation, I fixed this issue by passing proper faultCode from server to client.

Kindly review the fix.
Thanks.

[Alexis de Lattre (alexis-via)]

Hello !

What is blocking this fix from being merged in the stable branch ?

[Naresh(OpenERP) (nch-openerp)]

Hello,

This bug was qualified as Not Relevant on Trunk (means that architecture on trunk has changed and so this bug has no meaning anymore). If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Unmerged revisions

4265. By Ravi Gohil (OpenERP) on 2012-08-31

[FIX]: could not connect to server using netrpc from GTK-Client and '--no-database-list' parameter fed to server: (Maintenance Case : 578621)

=== modified file 'openerp/service/netrpc_server.py'
--- openerp/service/netrpc_server.py	2012-01-24 17:30:17 +0000
+++ openerp/service/netrpc_server.py	2012-08-31 09:40:50 +0000
@@ -96,7 +96,7 @@
     if isinstance(e, openerp.exceptions.AccessError):
         return 'warning -- AccessError\n\n' + str(e)
     if isinstance(e, openerp.exceptions.AccessDenied):
-        return 'AccessDenied ' + str(e)
+        return 'AccessDenied'
     return openerp.tools.exception_to_unicode(e)
 
 class TinySocketServerThread(threading.Thread,netsvc.Server):