Merge lp:~openerp-dev/openobject-server/6.1-opw-576295-rgo into lp:openobject-server/6.1

[Ravi Gohil (OpenERP)]

Hello,

If any file in `Attachments` is referring to a record, reading that record will throw traceback in GTK-Client.

Steps to reproduce the issue:

Go to Customer view, open record for `Agrolait` in form view, add an attachment for this record.

Reload the 'Agrolait' in form view, a traceback will be faced saying,
`TypeError: 'bool' object is not iterable`.

This fix fixes this issue. Kindly review it.

Thanks.

[Naresh(OpenERP) (nch-openerp)]

review: Approve

[Naresh(OpenERP) (nch-openerp)]

The issue is a result of a regression generated at 4069 <email address hidden> where the count=False was changed to count=count. Where as we expect ids and not the count from super here

[Olivier Dony (Odoo) (odo-openerp)]

Looks good, thanks! (And sorry for introducing the original mistake)

PS: as a workaround, installing base_calendar or document modules looks like it bypasses the issue

review: Approve

=== modified file 'openerp/addons/base/ir/ir_attachment.py'
--- openerp/addons/base/ir/ir_attachment.py	2012-03-09 10:04:29 +0000
+++ openerp/addons/base/ir/ir_attachment.py	2012-06-27 09:03:25 +0000
@@ -57,7 +57,7 @@
     def _search(self, cr, uid, args, offset=0, limit=None, order=None, context=None, count=False, access_rights_uid=None):
         ids = super(ir_attachment, self)._search(cr, uid, args, offset=offset,
                                                  limit=limit, order=order,
-                                                 context=context, count=count,
+                                                 context=context, count=False,
                                                  access_rights_uid=access_rights_uid)
         if not ids:
             if count: