Merge lp:~openerp-dev/openobject-server/6.1-opw-572709-skh into lp:openobject-server/6.1

Proposed by Somesh Khare
Status: Rejected
Rejected by: Xavier ALT
Proposed branch: lp:~openerp-dev/openobject-server/6.1-opw-572709-skh
Merge into: lp:openobject-server/6.1
Diff against target: 12 lines (+2/-0)
1 file modified
openerp/addons/base/ir/ir_attachment.py (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/6.1-opw-572709-skh
Reviewer Review Type Date Requested Status
Xavier ALT (community) Disapprove
Naresh(OpenERP) Pending
Review via email: mp+97187@code.launchpad.net

Description of the change

Hello,

[Fix]: Error re-opening created purchase order and customer invoice in form view in db without demo data.

Steps to reproduce:
1. Fresh db without demo data.
2. Install account module and create a invoice and validate it.
3. Switch to invoice list view and again switch to the form view.

Error occurred.

This branch fixes this issue.

Kindly review the branch and share your views on it.

Thanks,
Somesh Khare

To post a comment you must log in.
Revision history for this message
mvhman (michael-openrevolution) wrote :

seems to be working.
I think that this should be merged into next branch.

Thanks
Michael

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello,

This bug was qualified as Not reproducible on Trunk , If this Merge Proposal could not be merged in v6.1 at the release of v7.0, it will be closed.

Thanks,
Naresh Soni

Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi,

I'm rejecting this MP - as it's already fixed by the following server revid: <email address hidden>

Regards,
Xavier

review: Disapprove

Unmerged revisions

4101. By Somesh Khare

[FIX] ir.attachment : Error re-opening created purchase order and customer invoice in form view in db without demo data (Case: Ref 572709)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/addons/base/ir/ir_attachment.py'
2--- openerp/addons/base/ir/ir_attachment.py 2012-03-09 10:04:29 +0000
3+++ openerp/addons/base/ir/ir_attachment.py 2012-03-13 10:58:20 +0000
4@@ -59,6 +59,8 @@
5 limit=limit, order=order,
6 context=context, count=count,
7 access_rights_uid=access_rights_uid)
8+ if isinstance(ids, (str,int,long)):
9+ ids = [ids]
10 if not ids:
11 if count:
12 return 0