Merge lp:~openerp-dev/openobject-server/6.0-opw-513433-xal into lp:openobject-server/6.0

[Xavier ALT]

Hi,

This branch fix some common problems with res.log context value bigger than 250. This happen on object using log() method (by having _log_create = True set on object or calling log() manually) mixed with user having big "user context" (ex: tz: America/North_Dakota/New_Salem).

Please review this.

Cheers,
Xavier

[lp:~openerp-dev/openobject-server/6.0-opw-513433-xal]

3596. By Xavier ALT on 2012-02-29

[FIX] res.log: make sure create context size if not bigger that field size

=== modified file 'bin/addons/base/res/res_log.py'
--- bin/addons/base/res/res_log.py	2012-02-28 11:12:15 +0000
+++ bin/addons/base/res/res_log.py	2012-02-29 12:19:20 +0000
@@ -50,11 +50,29 @@
                        self._index_name)
 
     def create(self, cr, uid, vals, context=None):
+
+        def filter_context_value(c):
+            """filter unrequired value from context"""
+            # We remove user context and web client related value as those
+            # values will be re-set when accessing res.log item, depending
+            # on user or client settings
+            if isinstance(c, dict):
+                FILTER_OUT_KEYS = ['tz', 'lang', 'client', 'bin_size', '_terp_view_name']
+                for context_key in FILTER_OUT_KEYS:
+                    c.pop(context_key, None)
+            return c
         create_context = context and dict(context) or {}
         if 'res_log_read' in create_context:
             vals['read'] = create_context.pop('res_log_read')
         if create_context and not vals.get('context'):
             vals['context'] = create_context
+        log_context = filter_context_value(vals.get('context',{}))
+        if len(str(log_context)) > 250:
+            # if context is still bigger that field size, better lose the
+            # context completly instead of breaking later when user access
+            # res.log item
+            log_context = "{}"
+        vals['context'] = log_context
         return super(res_log, self).create(cr, uid, vals, context=context)
 
     # TODO: do not return secondary log if same object than in the model (but unlink it)