Merge lp:~openerp-dev/openobject-server/6.0-opw-18173-vro into lp:openobject-server/6.0

Proposed by Valencia Rodrigues (OpenERP)
Status: Rejected
Rejected by: Vo Minh Thu
Proposed branch: lp:~openerp-dev/openobject-server/6.0-opw-18173-vro
Merge into: lp:openobject-server/6.0
Diff against target: 12 lines (+1/-1)
1 file modified
bin/addons/base/ir/ir_model.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/6.0-opw-18173-vro
Reviewer Review Type Date Requested Status
Vo Minh Thu (community) Disapprove
Review via email: mp+79111@code.launchpad.net

Description of the change

Hello,

The 'selection' field of ir.model.fields is a char type field, which places a limit on the number of characters acceptable. Hence a fix is proposed to change the type of this field to text, to remove size restriction.

This will allow the user to specify any number of characters (and selection options) in this field.

Thanks

To post a comment you must log in.
Revision history for this message
Vo Minh Thu (thu) wrote :

This seems a small change but we don't allow database schema change in the stable branch. If necessary, you can answer with a workaround: use a many2one field instead of a selection field, and make it point to a new custom model with the necessary values. Additionally a widget='selection' can be use on the view for the many2one.

review: Disapprove

Unmerged revisions

3519. By Valencia Rodrigues (OpenERP)

[IMP] base : Removed size restriction from 'selection' field of ir.model.fields (Case:18173)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/addons/base/ir/ir_model.py'
2--- bin/addons/base/ir/ir_model.py 2011-09-29 05:09:38 +0000
3+++ bin/addons/base/ir/ir_model.py 2011-10-12 12:15:29 +0000
4@@ -187,7 +187,7 @@
5 help="The model this field belongs to"),
6 'field_description': fields.char('Field Label', required=True, size=256),
7 'ttype': fields.selection(_get_fields_type, 'Field Type',size=64, required=True),
8- 'selection': fields.char('Selection Options',size=128, help="List of options for a selection field, "
9+ 'selection': fields.text('Selection Options', help="List of options for a selection field, "
10 "specified as a Python expression defining a list of (key, label) pairs. "
11 "For example: [('blue','Blue'),('yellow','Yellow')]"),
12 'required': fields.boolean('Required'),