Odoo Server (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-server/6.0-change_the_size_of_selection_field-ado into lp:openobject-server/6.0

  1. 6.0-change_the_size_of_selection_field-ado
  2. Merge into 6.0
Proposed by Amit Dodiya (OpenERP)
Status: Rejected
Rejected by: Xavier ALT
Proposed branch: lp:~openerp-dev/openobject-server/6.0-change_the_size_of_selection_field-ado
Merge into: lp:openobject-server/6.0
Diff against target: 12 lines (+1/-1)
1 file modified
bin/addons/base/ir/ir_model.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/6.0-change_the_size_of_selection_field-ado
Reviewer Review Type Date Requested Status
Xavier ALT (community) Disapprove
Olivier Dony (Odoo) Pending
Review via email: mp+82493@code.launchpad.net

Description of the change

Hello,

While adding a new custom field type "Selection" the size of "Selection Option" is restricted to 128.
So i have increase the size of Selection Option.

Thanks,
Amit

To post a comment you must log in.
Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi Amit,

I will reject this one for v6.0 (no DB field size changes allowed on stable). Could you redo this one on trunk ?

Regards,
Xavier

review: Disapprove

Unmerged revisions

3541. By Amit Dodiya (OpenERP)

[FIX]: increase the size of selection field in ir_model_field

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/addons/base/ir/ir_model.py'
2--- bin/addons/base/ir/ir_model.py 2011-09-29 05:09:38 +0000
3+++ bin/addons/base/ir/ir_model.py 2011-11-17 05:10:40 +0000
4@@ -187,7 +187,7 @@
5 help="The model this field belongs to"),
6 'field_description': fields.char('Field Label', required=True, size=256),
7 'ttype': fields.selection(_get_fields_type, 'Field Type',size=64, required=True),
8- 'selection': fields.char('Selection Options',size=128, help="List of options for a selection field, "
9+ 'selection': fields.char('Selection Options',size=512, help="List of options for a selection field, "
10 "specified as a Python expression defining a list of (key, label) pairs. "
11 "For example: [('blue','Blue'),('yellow','Yellow')]"),
12 'required': fields.boolean('Required'),