Merge lp:~openerp-dev/openobject-server/6.0-bug-771784-rgo into lp:openobject-server/6.0

Proposed by Naresh(OpenERP)
Status: Rejected
Rejected by: Naresh(OpenERP)
Proposed branch: lp:~openerp-dev/openobject-server/6.0-bug-771784-rgo
Merge into: lp:openobject-server/6.0
Diff against target: 20 lines (+3/-6)
1 file modified
bin/addons/base/ir/ir_ui_view.py (+3/-6)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/6.0-bug-771784-rgo
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Disapprove
Review via email: mp+117570@code.launchpad.net

Description of the change

backport from trunk:revision-info :3391.2.1 <email address hidden>

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

This commit on trunk was reverted back @3473:<email address hidden> due to a regression on translation of shortcuts. Then it was decided to remove the editing of shortcuts from the client itself.
so the backport should be made on client from trunk @ 1913 <email address hidden>

I am rejecting this merge proposal !

Thanks,
Naresh

review: Disapprove

Unmerged revisions

3456. By Ravi Gohil (OpenERP)

[FIX] base :Editing the shortcut reflects in the view

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/addons/base/ir/ir_ui_view.py'
2--- bin/addons/base/ir/ir_ui_view.py 2011-04-06 10:05:07 +0000
3+++ bin/addons/base/ir/ir_ui_view.py 2012-08-01 05:55:23 +0000
4@@ -196,13 +196,10 @@
5
6 def get_sc(self, cr, uid, user_id, model='ir.ui.menu', context=None):
7 ids = self.search(cr, uid, [('user_id','=',user_id),('resource','=',model)], context=context)
8- results = self.read(cr, uid, ids, ['res_id'], context=context)
9- name_map = dict(self.pool.get(model).name_get(cr, uid, [x['res_id'] for x in results], context=context))
10+ results = self.read(cr, uid, ids, ['res_id','name'], context=context)
11+ available_menus = self.pool.get(model).search(cr, uid, [], context=context)
12 # Make sure to return only shortcuts pointing to exisintg menu items.
13- filtered_results = filter(lambda result: result['res_id'] in name_map, results)
14- for result in filtered_results:
15- result.update(name=name_map[result['res_id']])
16- return filtered_results
17+ return filter(lambda result: result['res_id'] in available_menus, results)
18
19 _order = 'sequence,name'
20 _defaults = {