Merge lp:~openerp-dev/openobject-client/6.1-opw-582620-rgo into lp:openobject-client/6.1

Proposed by Ravi Gohil (OpenERP)
Status: Merged
Approved by: Naresh(OpenERP)
Approved revision: 2102
Merged at revision: 2103
Proposed branch: lp:~openerp-dev/openobject-client/6.1-opw-582620-rgo
Merge into: lp:openobject-client/6.1
Diff against target: 23 lines (+3/-3)
1 file modified
bin/widget/view/form_gtk/ (+3/-3)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client/6.1-opw-582620-rgo
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Numérigraphe (community) bug reference in bzr commit Needs Fixing
Review via email:

Description of the change


Steps to reproduce:
- Install project_scrum module,
- Open a record from "Project/Product Backlogs" in form view,
- Double click on a record from "Task" tab and cancel it and try to re-open that record

You wont be able to open it second time and a traceback is thrown client side saying,
"RuntimeError: dictionary changed size during iteration"

I have fixed this issue, kindly review it.


To post a comment you must log in.
2101. By Launchpad Translations on behalf of openerp

Launchpad automatic translations update.

Revision history for this message
Numérigraphe (numerigraphe) wrote :

Will you please be so kind as to add the bug reference in the bazaar history with the following command ?
   bzr commit --unchanged --fixes lp:1091301
Lionel Sausin.

review: Needs Fixing (bug reference in bzr commit)
2102. By Ravi Gohil (OpenERP)

[FIX]: If we open an o2m field and close it without changing it, we wont be able to open it again. : (Maintenance Case : 582620)

Revision history for this message
Ravi Gohil (OpenERP) (rgo-openerp) wrote :

Hi Lionel,

I have updated this branch with --fixes lp:1091301.


Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/widget/view/form_gtk/'
--- bin/widget/view/form_gtk/ 2012-10-03 06:39:32 +0000
+++ bin/widget/view/form_gtk/ 2012-12-18 11:03:21 +0000
@@ -312,8 +312,8 @@
312 models = []312 models = []
313 for o2m_model in models:313 for o2m_model in models:
314 values = o2m_model.value.copy()314 values = o2m_model.value.copy()
315 model_value.setdefault(o2m_model, values)315 model_value[o2m_model] = values.copy()
316 group_model.setdefault(o2m_model, {})316 group_model[o2m_model] = {}
317 for key, val in values.iteritems():317 for key, val in values.iteritems():
318 if isinstance(val, ModelRecordGroup):318 if isinstance(val, ModelRecordGroup):
319 group_model[o2m_model][key] = val.models[:]319 group_model[o2m_model][key] = val.models[:]
@@ -324,7 +324,7 @@
324 def _restore_values(self, modified_model_values, group_model):324 def _restore_values(self, modified_model_values, group_model):
325 for model, value in modified_model_values.iteritems():325 for model, value in modified_model_values.iteritems():
326 model.set(value, modified=True)326 model.set(value, modified=True)
327 for f_name, models in group_model.get(model, {}):327 for f_name, models in group_model.get(model, {}).iteritems():
328 model.value[f_name].clear()328 model.value[f_name].clear()
329 for sub_model in models:329 for sub_model in models:
330 # add model in ModelRecordGroup330 # add model in ModelRecordGroup


People subscribed via source and target branches