Merge lp:~openerp-dev/openobject-client/6.1-opw-576759-rgo into lp:openobject-client/6.1

Proposed by Ravi Gohil (OpenERP)
Status: Merged
Approved by: Naresh(OpenERP)
Approved revision: 2067
Merged at revision: 2074
Proposed branch: lp:~openerp-dev/openobject-client/6.1-opw-576759-rgo
Merge into: lp:openobject-client/6.1
Diff against target: 34 lines (+3/-3)
2 files modified
bin/widget/view/form_gtk/float_time.py (+2/-2)
bin/widget/view/tree_gtk/parser.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client/6.1-opw-576759-rgo
Reviewer Review Type Date Requested Status
Naresh(OpenERP) (community) Approve
Review via email: mp+114566@code.launchpad.net

Description of the change

Hello,

There is an issue with float_time widget of GTK-Client, it uses locale format instead of OpenERP locale format.

Steps to reproduce:
1) Set the 'Decimal Separator' of Language to other than dot(.),
2) after installing hr_timesheet module, go to 'Human Resources/Time Tracking/Timesheet Lines' and give value for 'Quantity' with user's locale 'Decimal Separator',

For example, with 'Decimal Separator' set to *, enter value for 'Quantity' 1*5, which should be parsed to 01:30 instead it is parsed to 15:00.

This fix fixes this issue, kindly review it.

Thanks.

To post a comment you must log in.
Revision history for this message
Naresh(OpenERP) (nch-openerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/widget/view/form_gtk/float_time.py'
2--- bin/widget/view/form_gtk/float_time.py 2011-04-20 09:31:42 +0000
3+++ bin/widget/view/form_gtk/float_time.py 2012-07-12 06:15:24 +0000
4@@ -28,7 +28,7 @@
5
6 import common
7 import interface
8-from tools import datetime_util
9+from tools import user_locale_format, datetime_util
10
11 class float_time(interface.widget_interface):
12 def __init__(self, window, parent, model, attrs={}, label=None):
13@@ -50,7 +50,7 @@
14 if text and ':' in text:
15 return round(int(text.split(':')[0]) + int(text.split(':')[1]) / 60.0,4)
16 else:
17- return locale.atof(text)
18+ return user_locale_format.str2float(text)
19 except:
20 pass
21 return 0.0
22
23=== modified file 'bin/widget/view/tree_gtk/parser.py'
24--- bin/widget/view/tree_gtk/parser.py 2011-10-20 07:08:15 +0000
25+++ bin/widget/view/tree_gtk/parser.py 2012-07-12 06:15:24 +0000
26@@ -505,7 +505,7 @@
27 if text and ':' in text:
28 return round(int(text.split(':')[0]) + int(text.split(':')[1]) / 60.0,4)
29 else:
30- return locale.atof(text)
31+ return user_locale_format.str2float(text)
32 except:
33 pass
34 return 0.0

Subscribers

People subscribed via source and target branches