Merge lp:~openerp-dev/openobject-client/6.1-opw-575181-rha into lp:openobject-client/6.1

[Rifakat Husen (OpenERP)]

Hello,

When we have a language configured with thousand separator as white space then GTK
client should take care of the thousand separator as ' '.

Float values are correctly displayed whith white space in web client, but gtk doesn't.

Thanks for your review.

Regards,
Rifakat Haradwala

[Naresh(OpenERP) (nch-openerp)]

Hello,

The patch want fix anything because the default values for the separator, decimal point will be taken from the locale of the system if the language does not provide a one. so you want be able to have space there. something like :

>>> from locale import localeconv
>>> localeconv()
{'mon_decimal_point': '', 'int_frac_digits': 127, 'p_sep_by_space': 127, 'frac_digits': 127, 'thousands_sep': '', 'n_sign_posn': 127, 'decimal_point': '.', 'int_curr_symbol': '', 'n_cs_precedes': 127, 'p_sign_posn': 127, 'mon_thousands_sep': '', 'negative_sign': '', 'currency_symbol': '', 'n_sep_by_space': 127, 'mon_grouping': [], 'p_cs_precedes': 127, 'positive_sign': '', 'grouping': []}

If we want to allow white space as a thousand separator then we need to check that prior to assigning the default format values.

could please check this.

Thanks,
Naresh

review: Needs Information

Unmerged revisions

2064. By Rifakat Husen (OpenERP) on 2012-05-30

[FIX] tools: removed the code which was removing white space from the floeat values

=== modified file 'bin/tools/user_locale_format.py'
--- bin/tools/user_locale_format.py	2011-11-22 09:03:26 +0000
+++ bin/tools/user_locale_format.py	2012-05-30 07:26:18 +0000
@@ -186,11 +186,6 @@
             parts[0], seps = group(parts[0], monetary=monetary, grouping=lang_grouping, thousands_sep=thousands_sep)
 
         formatted = decimal_point.join(parts)
-        while seps:
-            sp = formatted.find(' ')
-            if sp == -1: break
-            formatted = formatted[:sp] + formatted[sp+1:]
-            seps -= 1
     elif percent[-1] in 'diu':
         if grouping:
             formatted = group(formatted, monetary=monetary, grouping=lang_grouping, thousands_sep=thousands_sep)[0]