Code review comment for lp:~openerp-dev/openobject-client/6.1-opw-573456-xal

Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi Naresh,

Just tested a new GTK build including your proposed fix, but this doesn't work - "image" widget stay blank.

I think this issue is essentially related to the fact that gtk.gdk.PixbufLoader() is mainly used for loading image progressively - generating "preview" of image based on current fetched data.

  But I think there is some heuristic in there that might delay generation of the "preview", so by using "close()" it only indicate to PixbufLoader() that there is no more data to come - and that is can generate the definite image buffer.

Cheers,
Xavier

« Back to merge proposal