Code review comment for lp:~openerp-dev/openobject-client/6.1-opw-573456-xal

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Xavier,

I think the problem does not seem to stem from missing the closing of the loader. but it may be due to lack of setting the fields value in the model field while adding new image !

nch@Naresh:~/workspace/OpenERP2012/6.1/client/bin$ bzr diff
=== modified file 'bin/widget/view/form_gtk/image.py'
--- bin/widget/view/form_gtk/image.py 2011-09-26 12:53:49 +0000
+++ bin/widget/view/form_gtk/image.py 2012-07-17 11:06:16 +0000
@@ -114,9 +114,11 @@
         if filename:
             self._value = encodestring(file(filename, 'rb').read())
             self.update_img()
+ self.set_value(self._view.model, self._view.model.mgroup.mfields[self.attrs['name']])
             if self.has_filename and self.has_filename in self._view.model.mgroup.mfields:
                 self._view.model.set({self.has_filename: os.path.basename(filename)}, modified=True)

can you please check with this....

Thanks,
Naresh

review: Needs Information

« Back to merge proposal