Merge lp:~openerp-dev/openobject-client/6.1-opw-573333-ado into lp:openobject-client/6.1

[Amit Dodiya (OpenERP)]

Hello,

"[FIX] Set filename when uploading an image is broken on 6.1"

Steps:
1). Goto : Settings/Customization/User Interface/Views
2). Open product.normal.form
3). Add "<field name="product_image" widget="image" nolabel="1" filename="default_code"/>" instead of "<field name="product_image" widget="image" nolabel="1"/>"
4). Try to upload image in product.

After adding filename tag "reference" is fill with the name but the field "product_images" is empty.

Thanks,
Amit

[lp:~openerp-dev/openobject-client/6.1-opw-573333-ado]

2058. By Launchpad Translations on behalf of openerp on 2012-04-18

Launchpad automatic translations update.

2059. By nel on 2012-05-09

[MERGE]

2060. By Launchpad Translations on behalf of openerp on 2012-05-13

Launchpad automatic translations update.

2061. By Launchpad Translations on behalf of openerp on 2012-05-15

Launchpad automatic translations update.

2062. By Launchpad Translations on behalf of openerp on 2012-05-16

Launchpad automatic translations update.

2063. By Launchpad Translations on behalf of openerp on 2012-05-24

Launchpad automatic translations update.

2064. By Launchpad Translations on behalf of openerp on 2012-06-07

Launchpad automatic translations update.

2065. By Launchpad Translations on behalf of openerp on 2012-06-14

Launchpad automatic translations update.

2066. By Launchpad Translations on behalf of openerp on 2012-07-01

Launchpad automatic translations update.

2067. By Naresh(OpenERP) on 2012-07-16

[MERGE]:Fix for OPW:576734

2068. By Naresh(OpenERP) on 2012-07-16

[MERGE]:OPW:573451

2069. By Naresh(OpenERP) on 2012-07-16

[MERGE]:OPW:575612

2070. By Naresh(OpenERP) on 2012-07-17

[MERGE]:OPW:576731

2071. By Naresh(OpenERP) on 2012-07-17

[MERGE]:OPW:576763

[Naresh(OpenERP) (nch-openerp)]

Hello Amit,

The issue is due to lack of setting the fields value in the model field while adding new image ! your fix will just bypass the root cause. It should be something like:
nch@Naresh:~/workspace/OpenERP2012/6.1/client/bin$ bzr diff
=== modified file 'bin/widget/view/form_gtk/image.py'
--- bin/widget/view/form_gtk/image.py 2011-09-26 12:53:49 +0000
+++ bin/widget/view/form_gtk/image.py 2012-07-17 11:06:16 +0000
@@ -114,9 +114,11 @@
         if filename:
             self._value = encodestring(file(filename, 'rb').read())
             self.update_img()
+ self.set_value(self._view.model, self._view.model.mgroup.mfields[self.attrs['name']])
             if self.has_filename and self.has_filename in self._view.model.mgroup.mfields:
                 self._view.model.set({self.has_filename: os.path.basename(filename)}, modified=True)

can you please test this and update your MP accordingly ?

Thanks,
Naresh

review: Needs Fixing

[lp:~openerp-dev/openobject-client/6.1-opw-573333-ado]

2072. By Launchpad Translations on behalf of openerp on 2012-07-19

Launchpad automatic translations update.

2073. By Naresh(OpenERP) on 2012-07-19

[MERGE]:OPW:576895

2074. By Naresh(OpenERP) on 2012-07-19

[MERGE]:OPW:576759

2075. By Amit Dodiya<email address hidden> on 2012-07-19

[FIX] Set filename when uploading an image is broken on 6.1

[Amit Dodiya (OpenERP) (ado-openerp)]

Hello,

Thanks for the suggestion.

I have check this and updated the code.

Regards,
Amit

review: Needs Resubmitting

[Naresh(OpenERP) (nch-openerp)]

review: Approve

=== modified file 'bin/widget/view/form_gtk/image.py'
--- bin/widget/view/form_gtk/image.py	2011-09-26 12:53:49 +0000
+++ bin/widget/view/form_gtk/image.py	2012-07-19 12:29:18 +0000
@@ -114,6 +114,7 @@
         if filename:
             self._value = encodestring(file(filename, 'rb').read())
             self.update_img()
+            self.set_value(self._view.model, self._view.model.mgroup.mfields[self.attrs['name']])
             if self.has_filename and self.has_filename in self._view.model.mgroup.mfields:
                 self._view.model.set({self.has_filename: os.path.basename(filename)}, modified=True)