Odoo GTK Client (MOVED TO GITHUB)

Merge lp:~openerp-dev/openobject-client/6.0-validation_O2M-rha into lp:openobject-client/6.0

  1. 6.0-validation_O2M-rha
  2. Merge into 6.0
Proposed by Rifakat Husen (OpenERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-client/6.0-validation_O2M-rha
Merge into: lp:openobject-client/6.0
Diff against target: 15 lines (+1/-4)
1 file modified
bin/widget/model/field.py (+1/-4)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client/6.0-validation_O2M-rha
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+68650@code.launchpad.net

Description of the change

validation on O2M field should not remove the child models

To post a comment you must log in.

Unmerged revisions

1871. By Rifakat(OpenERP)

[FIX]: validation on O2M field should not remove the child models

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/widget/model/field.py'
2--- bin/widget/model/field.py 2011-02-16 13:25:16 +0000
3+++ bin/widget/model/field.py 2011-07-21 10:03:30 +0000
4@@ -454,10 +454,7 @@
5 ok = True
6 for model2 in model.value[self.name].models:
7 if not model2.validate():
8- if not model2.is_modified():
9- model.value[self.name].models.remove(model2)
10- else:
11- ok = False
12+ ok = False
13 if not super(O2MField, self).validate(model):
14 ok = False
15 self.get_state_attrs(model)['valid'] = ok