Merge lp:~openerp-dev/openobject-client-web/trunk-bug-714557-vda into lp:openobject-client-web/trunk

[Vaibhav Darji]

When o2m found in inline editor overwrite edit_inline property.
So make them editable in popup.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

Broken: if I apply the patch on 6.0, go into project > project > task, make the tasks list editable inline and click to edit a task I get a CherryPy error, no error normally.

In GTK client, edition of line is still inline it's just that the widget for a multiline relation is the count (like "( 0 )") as when the line is not editable inline, and editing that cell does not do anything (ideally it would be readonly). Can't we do the same thing, instead of trying to display a list within a list?

review: Needs Fixing

[lp:~openerp-dev/openobject-client-web/trunk-bug-714557-vda]

4596. By vda(OpenERP) <email address hidden> on 2011-03-09

[FIX] if Hidden fields are in inline editors then Add Hidden fields only if editors is found.

[Vaibhav Darji (vaibhav-openerp)]

Committed for:if Hidden fields are in inline editors then Add Hidden fields only if editors is found.

[Vaibhav Darji (vaibhav-openerp)]

> Broken: if I apply the patch on 6.0, go into project > project > task, make
> the tasks list editable inline and click to edit a task I get a CherryPy
> error, no error normally.
I have checked this issue and solved it.
>
> In GTK client, edition of line is still inline it's just that the widget for a
> multiline relation is the count (like "( 0 )") as when the line is not
> editable inline, and editing that cell does not do anything (ideally it would
> be readonly). Can't we do the same thing, instead of trying to display a list
> within a list?
I think,this is efficient solution for it.otherwise we need to do changes in o2m-widget.and In the list we display count of ids for o2m currently too.

[Xavier (Open ERP) (xmo-deactivatedaccount)]

OK, project > project > task are not broken anymore but it still does not work right:

* Go into long term planning > plannings, with no planning
* [New] planning
* Enter a name
* Click on Time Encoding tab
* Click Planning Lines [New]
* In Qty UoM enter PCE and tab (for completion)
* Click Tasks [New]

In background you can see it creates a planning line, but it does not create a task.

review: Needs Fixing

[Vaibhav Darji (vaibhav-openerp)]

> OK, project > project > task are not broken anymore but it still does not work
> right:
>
> * Go into long term planning > plannings, with no planning
> * [New] planning
> * Enter a name
> * Click on Time Encoding tab
> * Click Planning Lines [New]
> * In Qty UoM enter PCE and tab (for completion)
> * Click Tasks [New]
>
> In background you can see it creates a planning line, but it does not create a
> task.

The bug you are describing is: https://bugs.launchpad.net/openobject-client-web/+bug/733089 which is separate issue than this one.
so this is not due to my change of code.

Thanks.

=== modified file 'addons/openerp/widgets/listgrid.py'
--- addons/openerp/widgets/listgrid.py	2011-02-15 09:04:57 +0000
+++ addons/openerp/widgets/listgrid.py	2011-03-09 12:43:13 +0000
@@ -224,14 +224,18 @@
                 if not isinstance(fa, int):
                     fa['prefix'] = '_terp_listfields' + ((self.name != '_terp_list' or '') and '/' + self.name)
                     fa['inline'] = True
-                    
+                    if fa.get('type') == 'one2many':
+                        self.edit_inline = False
+                        self.editors = {}
+                        break
                     Widget = get_widget(fa.get('type', 'char')) or get_widget('char')
                     self.editors[f] = Widget(**fa)
 
             # generate hidden fields
-            for f, fa in self.hiddens:
-                fa['prefix'] = '_terp_listfields' + ((self.name != '_terp_list' or '') and '/' + self.name)
-                self.editors[f] = form.Hidden(**fa)
+            if self.editors:
+                for f, fa in self.hiddens:
+                    fa['prefix'] = '_terp_listfields' + ((self.name != '_terp_list' or '') and '/' + self.name)
+                    self.editors[f] = form.Hidden(**fa)
 
         # limit the data
         if self.pageable and len(self.data) > self.limit and self.limit != -1: