Merge lp:~openerp-dev/openobject-client-web/6.0-opw-603776-msh into lp:openobject-client-web

[Mohammed Shekha(Open ERP)]

Hello,

Fixed the issue of openm2o with default one2many value doesn't save default one2many record, also onchange not fired for default values.

Demo: To produce this issue, you need to have a mnay2one object which has one2many and value of one2many comes from onchange which is fired by default_get value.
Scenario in current OpenERP module: Accounting -> Bank & Cash -> Bank Statement -> Transactions -> Add one2many record -> in Payment field press F1 -> Check m2o object will have one2many field but it will not load onchange value which is coming through partner_id change, when do change explicitly then one2many will have some value.

Also after getting one2many default record you will not be able to save it or delete it.

Issue is due to code of hashchange to trigger one2many if it is not not saved yet, there is an use of parent prefix, yes o2m will have parent prefix but m2o will not have parent prefix.

Also default_o2m is not added in data while saving o2m record.

Thanks.

Thanks.

Unmerged revisions

4919. By Mohammed Shekha(OpenERP)<email address hidden> on 2014-02-12

[FIX]Fixed the issue of openm2o with default one2many value doesn't save default one2many record, also onchange not fired for default values.

=== modified file 'addons/openerp/controllers/openm2o.py'
--- addons/openerp/controllers/openm2o.py	2011-01-17 11:57:11 +0000
+++ addons/openerp/controllers/openm2o.py	2014-02-21 06:29:08 +0000
@@ -55,6 +55,8 @@
             proxy = rpc.RPCProxy(params.model)
 
             if not params.id:
+                if params.default_o2m:
+                    data.update(params.default_o2m)
                 id = proxy.create(data, params.context)
                 params.ids = (params.ids or []) + [int(id)]
                 params.id = int(id)

=== modified file 'addons/openerp/static/javascript/openerp/openerp.base.js'
--- addons/openerp/static/javascript/openerp/openerp.base.js	2012-10-29 12:56:43 +0000
+++ addons/openerp/static/javascript/openerp/openerp.base.js	2014-02-21 06:29:08 +0000
@@ -300,10 +300,8 @@
              if (jQuery('[callback]').length){
                 name = jQuery('[callback]').first().attr('id');
                 var parent_prefix = name.indexOf('/') > -1 ? name.slice(0, name.lastIndexOf('/') + 1) : '';
-                if (parent_prefix != ''){
-                    if(jQuery(idSelector(parent_prefix + '_terp_id')).val() == 'False'){
-                        initial_onchange_triggers();
-                    }
+                if(jQuery(idSelector(parent_prefix + '_terp_id')).val() == 'False'){
+                    initial_onchange_triggers();
                 }
             }
             return;