Merge lp:~openerp-dev/openobject-client-web/6.0-opw-581192-cpa into lp:openobject-client-web

Proposed by Chirag Patel (OpenERP)
Status: Rejected
Rejected by: Xavier ALT
Proposed branch: lp:~openerp-dev/openobject-client-web/6.0-opw-581192-cpa
Merge into: lp:openobject-client-web
Diff against target: 10 lines (+1/-1)
1 file modified
addons/openerp/controllers/requests.py (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client-web/6.0-opw-581192-cpa
Reviewer Review Type Date Requested Status
Xavier ALT (community) Disapprove
Review via email: mp+132318@code.launchpad.net

Description of the change

Hello,

Closed request not display to user.

Demo:

Login with demo user and click on request(near home button).
Change any request state to close.

After that request will not display.

Thanks

To post a comment you must log in.
Revision history for this message
Xavier ALT (dex-phx) wrote :

Hi Chirag,

I will reject this MP because the current behaviour of web client is correct, i.e. only show active request.

The problem stated by the OPW 581192, is that we can't delete a user having requests on it.

For that problem there is two solution:
1. dis-activate the user, but not delete it
2. remove request (using Administration / Customization / Low Levels Objects / Requests), then delete the user.

If there is a real requirement to automatically delete requests then propose a MP for setting ondelete="cascade" for request user's from/to field.

Regards,
Xavier

review: Disapprove

Unmerged revisions

4890. By Chirag Patel (OpenERP)

[FIX] Fixed close request not display to user.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/controllers/requests.py'
2--- addons/openerp/controllers/requests.py 2011-01-17 11:57:11 +0000
3+++ addons/openerp/controllers/requests.py 2012-10-31 12:59:21 +0000
4@@ -48,5 +48,5 @@
5 ids, total = self.my()
6 return actions.execute(
7 rpc.RPCProxy('ir.actions.act_window')\
8- .for_xml_id('base', 'res_request-act'), domain=('id', 'in', ids)
9+ .for_xml_id('base', 'res_request-act'), domain=('act_to', '=', rpc.session.uid)
10 )