Merge lp:~openerp-dev/openobject-client-web/6.0-opw-513505-cpa into lp:openobject-client-web

Proposed by Chirag Patel (OpenERP)
Status: Merged
Approved by: Xavier ALT
Approved revision: 4765
Merged at revision: 4794
Proposed branch: lp:~openerp-dev/openobject-client-web/6.0-opw-513505-cpa
Merge into: lp:openobject-client-web
Diff against target: 32 lines (+3/-1)
2 files modified
addons/openerp/widgets/form/_form.py (+2/-1)
addons/openerp/widgets/form/templates/button.mako (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client-web/6.0-opw-513505-cpa
Reviewer Review Type Date Requested Status
Vaibhav Darji (community) Approve
Review via email: mp+95326@code.launchpad.net

Description of the change

Hello

Tool tip not display on the button.

Demo:
1) Set "help" attribute for button in any xml.
2) Mouse hover on that button.

Observed: Tooltip not display on the button.
Expected: Tooltip should be display when mouse hover on button.

Thanks.

To post a comment you must log in.
Revision history for this message
Vaibhav Darji (vaibhav-openerp) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/widgets/form/_form.py'
2--- addons/openerp/widgets/form/_form.py 2011-10-17 04:47:28 +0000
3+++ addons/openerp/widgets/form/_form.py 2012-03-01 09:42:19 +0000
4@@ -623,7 +623,7 @@
5 class Button(TinyInputWidget):
6
7 template = "/openerp/widgets/form/templates/button.mako"
8- params = ["btype", "id", "confirm", "icon", "target", "context", "default_focus"]
9+ params = ["btype", "id", "confirm", "icon", "target", "context", "default_focus", "help"]
10
11 visible = True
12 def __init__(self, **attrs):
13@@ -637,6 +637,7 @@
14 self.readonly = True
15 self.btype = attrs.get('special', attrs.get('type', 'workflow'))
16 self.context = attrs.get("context", {})
17+ self.help = attrs.get('help', '')
18 self.nolabel = True
19 self.target = ''
20 if self.icon:
21
22=== modified file 'addons/openerp/widgets/form/templates/button.mako'
23--- addons/openerp/widgets/form/templates/button.mako 2011-09-22 10:26:25 +0000
24+++ addons/openerp/widgets/form/templates/button.mako 2012-03-01 09:42:19 +0000
25@@ -2,6 +2,7 @@
26 id="${name}"
27 name="${name}"
28 type="button"
29+ title="${help}"
30 href="javascript: void(0)"
31 onclick="buttonClicked('${name}', '${btype}', '${model}', '${id}', getNodeAttribute(this, 'confirm'), '${target}', getNodeAttribute(this, 'context'));"
32 style="height: 20px;"