Merge lp:~openerp-dev/openobject-client-web/6.0-opw-19877-cpa into lp:openobject-client-web

Proposed by Chirag Patel (OpenERP)
Status: Merged
Approved by: Xavier ALT
Approved revision: 4726
Merged at revision: 4786
Proposed branch: lp:~openerp-dev/openobject-client-web/6.0-opw-19877-cpa
Merge into: lp:openobject-client-web
Diff against target: 15 lines (+5/-0)
1 file modified
addons/openerp/static/javascript/m2o.js (+5/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client-web/6.0-opw-19877-cpa
Reviewer Review Type Date Requested Status
Olivier Laurent (Open ERP) (community) Needs Information
Vaibhav Darji (community) Approve
Review via email: mp+81112@code.launchpad.net

Description of the change

Hello,

Auto result box not hide after select record form m2o popup.

Demo: Accounting > Suppliers > Suppliers Invoices
1. Create new Supplier Invoice.
2. Enter "a" in supplier(m2o field).
3. Auto result box comes with 10 result.
4. Click on magnificent glass icon, select one record from that popup.

Observed: Auto result box not hide after select record from popup.
Expected: Auto result box must hide after select record from popup.

Thanks.

To post a comment you must log in.
Revision history for this message
Vaibhav Darji (vaibhav-openerp) :
review: Approve
Revision history for this message
Vaibhav Darji (vaibhav-openerp) wrote :

Oops,

Autotext box remains open when you click anywhere else on form.
it should be closed when Autotext box loses focus.

review: Needs Fixing
Revision history for this message
Chirag Patel (OpenERP) (cpa-openerp) wrote :

Hello,

> Oops,
>
> Autotext box remains open when you click anywhere else on form.

  This is a other issue, thanks for pointing out.
  So rev:- 4726 solve the both issue.

> it should be closed when Autotext box loses focus.

Thanks.

Revision history for this message
Vaibhav Darji (vaibhav-openerp) :
review: Approve
Revision history for this message
Olivier Laurent (Open ERP) (olt) wrote :

Is this behavior platform specific ? (Windows only ?)

I have a different behavior:

 1. I enter "a" in Supplier
 2. I get an auto result box with 9 results
 3. I click on the magnifying glass icon
 4. a popup opens with 9 results (same as step 2)
 5. I click on one of the result
 6. another popup opens with 19 results, this one is not filtered on "a"
 7. I click on one of the result and this populate the Supplier field

PS: if I click on the "X" to close the popup, the second popup (with 19 results) is present, so when I click on the magnifying glass, 2 popups open, one with the filtered results and behind the first one another popup with all the results.

I could not reproduce your steps: the auto result box disappear when I click on the magnifying glass

Revision history for this message
Olivier Laurent (Open ERP) (olt) wrote :

See comment on 2011-11-22. I could not reproduce it following your steps.

review: Needs Information
Revision history for this message
Chirag Patel (OpenERP) (cpa-openerp) wrote :

> See comment on 2011-11-22. I could not reproduce it following your steps.

Yes this issue will not reproduce with my steps.
Before doing my step no.4 you must mouseover on auto result box.
Then you can reproduce issue.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/static/javascript/m2o.js'
2--- addons/openerp/static/javascript/m2o.js 2011-08-04 14:07:40 +0000
3+++ addons/openerp/static/javascript/m2o.js 2011-11-10 09:43:25 +0000
4@@ -87,6 +87,11 @@
5 jQuery(this.reference).change(jQuery.proxy(this, 'on_reference_changed'));
6 }
7
8+ var self = this;
9+ jQuery(idSelector("autoCompleteResults_" + this.name)).mouseout(function(){
10+ self.suggestionBoxMouseOver = false;
11+ });
12+
13 this.is_inline = name.indexOf('_terp_listfields/') == 0;
14
15 this.field._m2o = this;