Merge lp:~openerp-dev/openobject-client-web/6.0-opw-19869-cpa into lp:openobject-client-web

Proposed by Chirag Patel (OpenERP) on 2011-11-03
Status: Merged
Approved by: Olivier Laurent (Open ERP) on 2011-11-21
Approved revision: 4726
Merge reported by: Olivier Laurent (Open ERP)
Merged at revision: not available
Proposed branch: lp:~openerp-dev/openobject-client-web/6.0-opw-19869-cpa
Merge into: lp:openobject-client-web
Diff against target: 11 lines (+1/-0)
1 file modified
addons/openerp/widgets/form/templates/datetime.mako (+1/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-client-web/6.0-opw-19869-cpa
Reviewer Review Type Date Requested Status
Olivier Laurent (Open ERP) (community) 2011-11-03 Approve on 2011-11-21
Vaibhav Darji (community) Approve on 2011-11-10
Review via email: mp+81143@code.launchpad.net

Description of the change

Hello,

Datepicker triggers keyboard / UI lock under IE Internet Explorer

Demo: Project > Task
1. Create new Task.
2. Click on calendar icon to open datepicker in Deadline field.
3. Select a date OR close datepicker without selecting a date

Observed: Can't fill any field in whole form(key event not detach after hide datepicker).

Thanks.

To post a comment you must log in.
Vaibhav Darji (vaibhav-openerp) wrote :

Do not do any changes in Calendar Library.
you can do the same code in widget onClose.

review: Needs Fixing
4726. By Chirag Patel (OpenERP) on 2011-11-09

[FIX] Fixed review code.

review: Approve
Olivier Laurent (Open ERP) (olt) wrote :

I could reproduce the bug under IE. The issue is fixed by your patch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/openerp/widgets/form/templates/datetime.mako'
2--- addons/openerp/widgets/form/templates/datetime.mako 2011-01-11 14:53:37 +0000
3+++ addons/openerp/widgets/form/templates/datetime.mako 2011-11-09 11:27:48 +0000
4@@ -18,6 +18,7 @@
5 showsTime: ${str(picker_shows_time).lower()},
6 onClose: function(cal){
7 cal.destroy();
8+ cal.hide();
9 }
10 });
11 });