Merge lp:~openerp-dev/openobject-addons/trunk-opw-581494-rha into lp:openobject-addons

[Rifakat Husen (OpenERP)]

Hello,

It is possible to change product on Production Lot while stock move
is also refers to it. We should not let any user change the product if
stock move is associated.

I have put attrs on product, it becomes readonly when there is any stock move
refers to Production Lot. Also overrided write(), so that it can't be changed
through any webservice.

Thanks for your review.

Regards,
Rifakat Haradwala

[lp:~openerp-dev/openobject-addons/trunk-opw-581494-rha]

7955. By Quentin (OpenERP) <email address hidden> on 2012-11-06

[MERGE] fix in account_voucher (bug spotted by nel)

7956. By Vo Minh Thu on 2012-11-06

[MERGE] removed a few warnings.

7957. By Thibault Delavallée (OpenERP) on 2012-11-06

[MERGE] Introducing the Many2Many Email Widget, based on Many2Many Tags. This widget designed for many2many fields on partners checks that partners added in the widget have an email address defined; if not, a popup is opened to enter an email.

Also featuring in a 'by the way' fashion:
- the 'Compose' button now opens a mail.compose.message wizard, without using further Chatter values.

[Numérigraphe (numerigraphe)]

I think write() should always refuse to change the product, even when no moves exist, because other objects could relate to product_id and we have no way to know.
Lionel

review: Needs Fixing

[lp:~openerp-dev/openobject-addons/trunk-opw-581494-rha]

7958. By Olivier Dony (Odoo) on 2012-11-06

[FIX] l10n_*: ensure install wizard triggers are in `noupdate` blocks, to avoid spurious wizards at update

7959. By Fabien (Open ERP) on 2012-11-06

[IMP] Expenses configuration menu simplified

7960. By Fabien (Open ERP) on 2012-11-06

[IMP] typo

7961. By Fabien (Open ERP) on 2012-11-06

[IMP] note CSS

7962. By Launchpad Translations on behalf of openerp on 2012-11-07

Launchpad automatic translations update.

7963. By Rifakat Husen (OpenERP) on 2012-11-07

[FIX] stock: remove checking on moves, always product can not be changed

[Rifakat Husen (OpenERP) (rha-openerp)]

Thanks Lionel, you are right. Corrected!

[Numérigraphe (numerigraphe)]

Thanks for the change.
Can the field could be readonly when id is not null please?

[lp:~openerp-dev/openobject-addons/trunk-opw-581494-rha]

7964. By Rifakat Husen (OpenERP) on 2012-11-07

[FIX] stock: improved attrs to be able to make product invisible as soon as we save form

Unmerged revisions

7964. By Rifakat Husen (OpenERP) on 2012-11-07

[FIX] stock: improved attrs to be able to make product invisible as soon as we save form

7963. By Rifakat Husen (OpenERP) on 2012-11-07

[FIX] stock: remove checking on moves, always product can not be changed

=== modified file 'stock/stock.py'
--- stock/stock.py	2012-11-06 15:04:31 +0000
+++ stock/stock.py	2012-11-07 10:51:46 +0000
@@ -1555,6 +1555,16 @@
     _sql_constraints = [
         ('name_ref_uniq', 'unique (name, ref)', 'The combination of serial number and internal reference must be unique !'),
     ]
+    
+    def write(self, cr, uid, ids, vals, context=None):
+        if 'product_id' in vals:
+            for production_lot in self.browse(cr, uid, ids, context=context):
+                if vals['product_id'] != production_lot.product_id.id:
+                    raise osv.except_osv(_('Warning!'), _('You can not change product in this Serial Number once \
+any product has been assigned to it. \
+Please create a new Serial Number for your product!'))
+        return super(stock_production_lot, self).write(cr, uid, ids, vals, context=context)
+    
     def action_traceability(self, cr, uid, ids, context=None):
         """ It traces the information of a product
         @param self: The object pointer.

=== modified file 'stock/stock_view.xml'
--- stock/stock_view.xml	2012-10-30 04:49:18 +0000
+++ stock/stock_view.xml	2012-11-07 10:51:46 +0000
@@ -348,7 +348,8 @@
                     </div>
                     <group>
                         <group>
-                            <field name="product_id"/>
+                            <field name="id" invisible="1"/>
+                            <field name="product_id" attrs="{'readonly': [('id', '!=', False)]}"/>
                             <field name="prefix"/>
                             <field name="ref"/>
                         </group>